Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some OWNERS files #77039

Merged
merged 3 commits into from
May 2, 2019
Merged

Update some OWNERS files #77039

merged 3 commits into from
May 2, 2019

Conversation

cblecker
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This updates some OWNERS files.

Key changes:

  • Swaps out @grodrigues3 for @nikhita in the GitHub issue templates
  • Alpha sort the build/ OWNERS file
  • Prune and alpha sort the hack/ OWNERS file

I looked at folks who hadn't done an approval in the last 6 months in the hack/ directory, and pruned out the folks:

If any of you three are planning on getting active again and would like me to add you back to the file, please let me know. Will leave this open for a few days for comment.

cc other hack/ OWNERS: @BenTheElder, @deads2k, @dims, @eparis, @fejta, @ixdy, @jbeda, @lavalamp, @pwittrock, @liggitt, @soltysh, @spiffxp, @sttts, @vishh, @zmerlynn

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2019
@cblecker
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2019
@cblecker
Copy link
Member Author

/sig release testing
/priority backlog

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2019
@cblecker cblecker changed the title Update owners Update some OWNERS files Apr 25, 2019
@dims
Copy link
Member

dims commented Apr 25, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member Author

No objections.. I'm going to start lazy consensus, and merge after Monday at 5pm PT. Speak now if you object.

@justaugustus justaugustus added this to Backlog in SIG Release Apr 28, 2019
@cblecker
Copy link
Member Author

cblecker commented May 2, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0230664 into kubernetes:master May 2, 2019
SIG Release automation moved this from Backlog to Done May 2, 2019
@cblecker cblecker deleted the update-owners branch May 2, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castrojo castrojo Awaiting requested review from castrojo

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cblecker @dims @k8s-ci-robot