Follow on for Store parsed CIDRs at initialization of Proxier #76779

[tedyu]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR addresses review comments from #76779.

For err checking in parseExcludedCIDRs, I think the current form should be fine since it has 3 lines while the suggested alternative has 4 lines.

NONE

[k8s-ci-robot]

Hi @tedyu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tedyu]

/assign @andrewsykim

[andrewsykim]

Do you think it still makes sense to flip the err check here and add logging if ParseCIDR fails?

if err != nil {
     klog.Errorf("Error parsing exclude CIDR %q,  err: %v", excludedCIDR, err)
     continue
}

cidrExclusions = append(cidrExclusions, n)

[tedyu]

I have changed the code as suggested.

[andrewsykim]

/ok-to-test
/priority backlog

[andrewsykim]

/lgtm
/assign @m1093782566
for approval

Thanks for iterating

[m1093782566]

/approve

Thanks all!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1093782566, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/proxy/ipvs/OWNERS [m1093782566]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment