Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cluster Autoscaler to 1.13.4 #77065

Merged
merged 1 commit into from
May 7, 2019
Merged

Update Cluster Autoscaler to 1.13.4 #77065

merged 1 commit into from
May 7, 2019

Conversation

losipiuk
Copy link
Contributor

@losipiuk losipiuk commented Apr 25, 2019 •
edited 

Update Cluster Autoscaler to 1.13.4
 - https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.13.4 
 - https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.13.3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 25, 2019
@losipiuk
Copy link
Contributor Author

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2019
@losipiuk
Copy link
Contributor Author

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Apr 25, 2019
@losipiuk
Copy link
Contributor Author

/retest

@losipiuk
Copy link
Contributor Author

/assign @MaciekPytel @mwielgus

@MaciekPytel
Copy link
Contributor

/lgmt
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@losipiuk
Copy link
Contributor Author

/assign @aleksandra-malinowska

@tpepper
Copy link
Member

tpepper commented Apr 30, 2019

Could we get a little more detail on why this version is being changed? What does .4 bring versus prior?

Also the release note: The commit shows a change from .2 to .4 but the release note mentions .3 and .4 which is a little strange.

@losipiuk
Copy link
Contributor Author

losipiuk commented May 6, 2019

Could we get a little more detail on why this version is being changed? What does .4 bring versus prior?

The .3 updates the base docker image used for CA to mitigate security vulnerabilities and fixes some bugs in AWS/AKS cloud providers.
The .4 fixes one more bug in AWS cloud provider.

Also the release note: The commit shows a change from .2 to .4 but the release note mentions .3 and .4 which is a little strange.

Why so? The sum of release notes for .3 and .4 is what is actually changing when when we move from CA .2 to .4.

@losipiuk losipiuk mentioned this pull request May 6, 2019
Merged
@tpepper
Copy link
Member

tpepper commented May 6, 2019

Why so? The sum of release notes for .3 and .4 is what is actually changing when when we move from CA .2 to .4.

OOOOooooh I see what you're trying to indicate. I take it as implied that a given point version includes content from prior point versions. 🤷

Security updates are definitely something for which we'd pull in an image patch version.

Please make sure the merge criteria are met and we will cherry-pick-approve.

@tpepper
Copy link
Member

tpepper commented May 6, 2019

/lgtm
to make up for typo in #77065 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2019
@losipiuk
Copy link
Contributor Author

losipiuk commented May 6, 2019

/retest

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6c741eb into kubernetes:release-1.13 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@tpepper tpepper

@aleksandra-malinowska aleksandra-malinowska

@MaciekPytel MaciekPytel

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@losipiuk @MaciekPytel @k8s-ci-robot @tpepper @aleksandra-malinowska @mwielgus