-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new cases to apiextensions-apiserver integration testing #77090
Conversation
/cc @liggitt |
/release-note-none |
/test pull-kubernetes-node-e2e |
}, | ||
} | ||
if _, err := noxuResourceClient.Create(typedNoBodyInstance, metav1.CreateOptions{}); !errors.IsInvalid(err) { | ||
t.Errorf("expected badrequest for submitting empty object, got %#v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not, message says "badrequest" but we expect IsInvalid
|
||
typedNoBodyInstance.SetName("foo") | ||
if _, err := noxuResourceClient2.Update(typedNoBodyInstance, metav1.UpdateOptions{}); !errors.IsInvalid(err) { | ||
t.Errorf("expected badrequest for submitting empty object, got %#v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/badrequest/invalid/
/kind cleanup |
/approve one nit on the error message |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sbezverk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-integration |
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
@liggitt it looks like it is ready, ptal |
/lgtm |
Signed-off-by: Serguei Bezverkhi sbezverk@cisco.com
Adding two cases when Unstructured object has either no type at all or has insufficient information.