Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #76773: Create the "internal" firewall rule for kubemark master. #77118

Merged
merged 1 commit into from
May 2, 2019
Merged

Automated cherry pick of #76773: Create the "internal" firewall rule for kubemark master. #77118

merged 1 commit into from
May 2, 2019

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Apr 26, 2019 •
edited

Cherry pick of #76773 on release-1.13.

#76773: Create the "internal" firewall rule for kubemark master.

NONE

@mm4tt
Create the "internal" firewall rule for kubemark master.
7db8743 
This is equivalent to the "internal" firewall rule that is created for
the regular masters.
The main reason for doing it is to allow prometheus scraping metrics
from various kubemark master components, e.g. kubelet.

Ref. kubernetes/perf-tests#503
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 26, 2019
@mm4tt mm4tt mentioned this pull request Apr 26, 2019
Closed
@feiskyer
Copy link
Member

/lgtm
/kind failing-test
/priority critical-urgent
/sig testing

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 26, 2019
@wojtek-t
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@wojtek-t wojtek-t added this to the v1.13 milestone Apr 26, 2019
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 29, 2019
mm4tt added a commit to mm4tt/test-infra that referenced this pull request Apr 29, 2019
@mm4tt
WIP re-enable prometheus server in scalability tests
7f0578c 
All cherypicks have been merged: kubernetes/kubernetes#77117, kubernetes/kubernetes#77118, kubernetes/kubernetes#77119, kubernetes/kubernetes#77120.

Ref. kubernetes/kubernetes#73105
@mm4tt mm4tt mentioned this pull request Apr 29, 2019
Merged
@tpepper
Copy link
Member

tpepper commented Apr 30, 2019

While the original issue reference and the PR being cherry-picked both show as "feature" and thus not a candidate for cherry pick, as per #73105 this appears to be a failing test fix and useful to cherry pick.

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 2, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6254e79 into kubernetes:release-1.13 May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mm4tt @feiskyer @wojtek-t @k8s-ci-robot @tpepper