Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint failures in cmd/kube-controller-manager #77189

Merged
merged 1 commit into from
May 16, 2019
Merged

Fix golint failures in cmd/kube-controller-manager #77189

merged 1 commit into from
May 16, 2019

Conversation

xiaojingchen
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does?:

fix golint failures in cmd/kube-controller-manager

Which issue(s) this PR fixes:

Ref: #68026

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

@xiaojingchen: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @xiaojingchen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 28, 2019
@draveness
Copy link
Contributor

draveness commented Apr 28, 2019 •
edited

/ok-to-test
/priority backlog
/release-note-none

please rebase the master and squash the commits into one.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 28, 2019
@xiaojingchen
Copy link
Contributor Author

/assign @sttts @dims

@xiaojingchen
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@SataQiu
Copy link
Member

SataQiu commented Apr 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2019
@fedebongio
Copy link
Contributor

/assign @cheftako

@fedebongio
Copy link
Contributor

/cc @yuwenma

@xiaojingchen
Copy link
Contributor Author

/assign @sttts @deads2k @cblecker

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@cofyc
Copy link
Member

cofyc commented May 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@xiaojingchen
Copy link
Contributor Author

/assign @deads2k

1 similar comment
@xiaojingchen
Copy link
Contributor Author

/assign @deads2k

@spiffxp
Copy link
Member

spiffxp commented May 11, 2019

/approve

@SataQiu
Copy link
Member

SataQiu commented May 11, 2019

/assign @thockin

@xiaojingchen
Copy link
Contributor Author

/assign @sttts @deads2k

sttts
sttts reviewed May 15, 2019
View reviewed changes
cmd/kube-controller-manager/app/import_known_versions.go
import (
// These imports are the API groups the client will support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is probably wrong nowadays. But it was wrong before, so ok.

@sttts
Copy link
Contributor

sttts commented May 15, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp, sttts, xiaojingchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@thockin thockin removed their assignment May 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit aba8040 into kubernetes:master May 16, 2019
@xiaojingchen xiaojingchen deleted the fix-golint-failures branch May 16, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@SataQiu SataQiu SataQiu left review comments

@bowei bowei Awaiting requested review from bowei

@sjenning sjenning Awaiting requested review from sjenning

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@dims dims

@cofyc cofyc

@sttts sttts

@cheftako cheftako

@cblecker cblecker

@deads2k deads2k

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet