Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #76974: Restrict builds to officially supported platforms #77214

Merged
merged 1 commit into from
May 1, 2019
Merged

Automated cherry pick of #76974: Restrict builds to officially supported platforms #77214

merged 1 commit into from
May 1, 2019

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Apr 29, 2019 •
edited

Cherry pick of #76974 on release-1.14.

#76974: Restrict builds to officially supported platforms

NONE

@mtaufen
Restrict builds to officially supported platforms
ffa6160 
Prior to this change, including windows/amd64 in KUBE_BUILD_PLATFORMS
would, for example, attempt to build the server binaries/tars/images for
Windows, which is not supported. This can break downstream build steps.
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 29, 2019
@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

/sig windows
/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 29, 2019
@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

This fixes a critical bug that breaks certain release workflows that try to build Linux and Windows binaries, but not build every supported arch.

@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019 •
edited

/assign @hoegaarden @aleksandra-malinowska @tpepper
Can one of you please approve the cherry-pick?

/cc @thockin @yujuhong

@yujuhong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2019
@yujuhong
Copy link
Contributor

/test pull-kubernetes-godeps

@yujuhong yujuhong added this to the v1.14 milestone Apr 29, 2019
@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

/retest

@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

Filed a bug for the godeps test: #77238

@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 30, 2019

/retest
godeps test should be fixed now

@hoegaarden
Copy link
Contributor

@mtaufen

Can one of you please approve the cherry-pick?

The cherrypick needs to be approved by one of the /hack approvers.

@fejta
Copy link
Contributor

fejta commented Apr 30, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
thockin
thockin reviewed Apr 30, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, mtaufen, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yujuhong
Copy link
Contributor

/assign @tpepper @aleksandra-malinowska
for cherrypick approval

@yujuhong
Copy link
Contributor

yujuhong commented May 1, 2019

Ping! 1.14 patch managers, could you take a look at this PR? Thanks!

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 1, 2019
@mtaufen mtaufen removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 68099ce into kubernetes:release-1.14 May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@fejta fejta Awaiting requested review from fejta

@vishh vishh Awaiting requested review from vishh

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@hoegaarden hoegaarden

@tpepper tpepper

@aleksandra-malinowska aleksandra-malinowska

@thockin thockin

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mtaufen @yujuhong @hoegaarden @fejta @k8s-ci-robot @thockin @tpepper @aleksandra-malinowska