Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pd-external from e2e config #77233

Merged
merged 1 commit into from
Apr 30, 2019
Merged

remove pd-external from e2e config #77233

merged 1 commit into from
Apr 30, 2019

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Apr 29, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
PD CSI driver framework is switching to use the e2e external framework in kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#249

Which issue(s) this PR fixes:

Fixes #70258

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 29, 2019
@msau42
Copy link
Member Author

msau42 commented Apr 29, 2019

/assign @davidz627
/hold
until the new framework has merged and confirmed success

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 29, 2019
@msau42
Copy link
Member Author

msau42 commented Apr 29, 2019

/priority important-longterm
/sig storage

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 29, 2019
@davidz627
Copy link
Contributor

We probably should also remove this: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/csi_volumes.go#L37

@msau42
remove pd-external from e2e config
80471bf 
Change-Id: I1d734fcc8e8145e586b5df9acd0736c7ba0658d1
@msau42
Copy link
Member Author

msau42 commented Apr 29, 2019

whoooooops repushed

@davidz627
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2019
@msau42
Copy link
Member Author

msau42 commented Apr 30, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit aedebb2 into kubernetes:master Apr 30, 2019
@msau42 msau42 deleted the remove-pd-external branch October 19, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs Awaiting requested review from rootfs

@verult verult Awaiting requested review from verult

Assignees

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove out of tree pd test config
3 participants
@msau42 @k8s-ci-robot @davidz627