Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused quorum field #77281

Merged
merged 1 commit into from
May 2, 2019
Merged

Remove unused quorum field #77281

merged 1 commit into from
May 2, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Apr 30, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes unused, misleading Quorum field from storage config struct

Does this PR introduce a user-facing change?:

NONE

/sig api-machinery
/cc MikeSpreitzer

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Apr 30, 2019
@liggitt liggitt mentioned this pull request Apr 30, 2019
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
@apelisse
Copy link
Member

apelisse commented May 2, 2019

/assign @jpbetz

@jpbetz
Copy link
Contributor

jpbetz commented May 2, 2019

Yep, explicitly requesting quorum reads was an etcd2 thing (in etcd3, if you don't want a quorum read, you must explicitly request a "serializable" read instead of a "linearizable" one). Thanks for cleaning it up.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit c821eb3 into kubernetes:master May 2, 2019
@liggitt liggitt deleted the remove-quorum-field branch May 6, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeSpreitzer MikeSpreitzer MikeSpreitzer approved these changes

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @apelisse @jpbetz @MikeSpreitzer