Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the dynamic volume limit in GCE PD #77311

Merged
merged 1 commit into from
May 6, 2019
Merged

Update the dynamic volume limit in GCE PD #77311

merged 1 commit into from
May 6, 2019

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented May 1, 2019 •
edited by saad-ali

Currently GCE PD support 128 maximum disks attached to a node for all
machines types except shared-core. This PR updates the limit number to
date.

Change-Id: Id9dfdbd24763b6b4138935842c246b1803838b78

Change the maximum disks attached per node for GCE PDs to 128 for all machines types except shared-core which will be 16.

@jingxu97
Update the dynamic volume limit in GCE PD
b01e2a3 
Currently GCE PD support 128 maximum disks attached to a node for all
machines types except shared-core. This PR updates the limit number to
date.

Change-Id: Id9dfdbd24763b6b4138935842c246b1803838b78
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 1, 2019
@jingxu97 jingxu97 requested a review from msau42 May 1, 2019 17:39
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 1, 2019
@msau42
Copy link
Member

msau42 commented May 1, 2019

/kind bug
/priority important-soon

/lgtm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 1, 2019
@saad-ali
Copy link
Member

saad-ali commented May 1, 2019

/lgtm
/approve

@saad-ali
Copy link
Member

saad-ali commented May 1, 2019

Assigning patch release managers:
/assign @aleksandra-malinowska
/assign @tpepper

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2019
@tpepper tpepper mentioned this pull request May 2, 2019
Merged
@tpepper
Copy link
Member

tpepper commented May 6, 2019

/hold
pending description of what bug is solved by this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2019
@saad-ali
Copy link
Member

saad-ali commented May 6, 2019

@tpepper The GCE platform changed the number of disks that are supported per node. These PRs are updating those limits on the k8s side. The change is on the edge between a bug and a feature. But since we've gotten customer complaints about it (it appears to customers like a bug), we'd like to cherry pick it.

@tpepper
Copy link
Member

tpepper commented May 6, 2019

Since this is small, provider specific, and SIG approved, will merge.

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 6, 2019
@tpepper
Copy link
Member

tpepper commented May 6, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 049611b into kubernetes:release-1.14 May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali approved these changes

@msau42 msau42 Awaiting requested review from msau42

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@tpepper tpepper

@aleksandra-malinowska aleksandra-malinowska

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jingxu97 @msau42 @saad-ali @k8s-ci-robot @tpepper @aleksandra-malinowska