Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated gce node-termination-handler yaml. #77358

Merged
merged 1 commit into from
May 14, 2019
Merged

Updated gce node-termination-handler yaml. #77358

merged 1 commit into from
May 14, 2019

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented May 2, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
We push a new release for image node-termination-handler which is based on distroless.
new image
Image Rebase: GoogleCloudPlatform/k8s-node-termination-handler#12
taint flag: GoogleCloudPlatform/k8s-node-termination-handler#13
example yaml: GoogleCloudPlatform/k8s-node-termination-handler#14

Which issue(s) this PR fixes:

Fixes #
GoogleCloudPlatform/k8s-node-termination-handler#13

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2019
@yuwenma
Copy link
Contributor Author

yuwenma commented May 2, 2019

/cc @mindprince @vishh

@yuwenma
Copy link
Contributor Author

yuwenma commented May 2, 2019

/assign @jszczepkowski

@vishh
Copy link
Contributor

vishh commented May 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2019
@vishh
Copy link
Contributor

vishh commented May 6, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2019
@vishh
Copy link
Contributor

vishh commented May 6, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2019
@vishh vishh removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2019
@jszczepkowski jszczepkowski removed their assignment May 7, 2019
@yuwenma
Copy link
Contributor Author

yuwenma commented May 7, 2019

/assign @gmarek
/assign @yujuhong

The auto-assigned approver no longer works in this area. Reassign to other approvers of the gce dir.

@vishh
Copy link
Contributor

vishh commented May 13, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vishh, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2c67fb3 into kubernetes:master May 14, 2019
@Duologic Duologic mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishh vishh vishh left review comments

@rohitagarwal003 rohitagarwal003 Awaiting requested review from rohitagarwal003

@jingax10 jingax10 Awaiting requested review from jingax10

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@gmarek gmarek

@vishh vishh

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yuwenma @vishh @k8s-ci-robot @gmarek @yujuhong @jszczepkowski