Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #76675: Error when etcd3 watch finds delete event with nil prevKV #77394

Merged
merged 1 commit into from
May 7, 2019
Merged

Automated cherry pick of #76675: Error when etcd3 watch finds delete event with nil prevKV #77394

merged 1 commit into from
May 7, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 3, 2019

Cherry pick of #76675 on release-1.13.

#76675: Error when etcd3 watch finds delete event with nil prevKV

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2019
@liggitt
Copy link
Member Author

liggitt commented May 3, 2019

/priority critical-urgent
/sig api-machinery
/kind bug
/assign @tpepper @aleksandra-malinowska @jpbetz
/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone May 3, 2019
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/bug Categorizes issue or PR as related to a bug. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 3, 2019
@jpbetz
Copy link
Contributor

jpbetz commented May 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2019
@jpbetz
Copy link
Contributor

jpbetz commented May 3, 2019

/retest

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 6, 2019
@tpepper
Copy link
Member

tpepper commented May 6, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 978a0a8 into kubernetes:release-1.13 May 7, 2019
@liggitt liggitt deleted the automated-cherry-pick-of-#76675-upstream-release-1.13 branch August 19, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhusudancs madhusudancs Awaiting requested review from madhusudancs

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@jpbetz jpbetz

@tpepper tpepper

@aleksandra-malinowska aleksandra-malinowska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @jpbetz @tpepper @aleksandra-malinowska