Move scalability, upgrade, and common packages to framework/log #77408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/test pull-kubernetes-bazel-build |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
/assign @timothysc |
k8s-ci-robot
added
the
needs-rebase
This is part of the transition to using framework/log instead of the Logf inside the framework package. This will help with import size/cycles when importing the framework or subpackages.
johnSchnake
force-pushed
the
frameworkLogRefactoringCommonScaleUpgrades
branch
from
c327e7d
to
afc66a5
Compare
k8s-ci-robot
removed
lgtm
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnSchnake, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is part of the transition to using framework/log instead
of the Logf inside the framework package. This will help with
import size/cycles when importing the framework or subpackages.
Which issue(s) this PR fixes:
Ref #77359
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/sig testing
/area test
/area test-framework