Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OWNERS file for gce/manifests #77424

Merged
merged 1 commit into from
May 10, 2019
Merged

Add OWNERS file for gce/manifests #77424

merged 1 commit into from
May 10, 2019

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented May 3, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Adding an OWNERS file (that includes myself) to gce/manifest so I can help reviewing/approving changes like #77282.

Which issue(s) this PR fixes:

Fixes #NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 3, 2019
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 3, 2019
@yujuhong
Copy link
Contributor

yujuhong commented May 3, 2019 •
edited

Looks good but I think it's good to have more than one approver if possible.
@tallclair would you like to be an owner?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2019
@MrHohn
Copy link
Member Author

MrHohn commented May 9, 2019

Added @tallclair as an OWNER as that makes total sense :)

To keep this rolling
/assign @tallclair

@yujuhong
Copy link
Contributor

yujuhong commented May 9, 2019

/approve

Leaving lgtm to @tallclair

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
@tallclair
Copy link
Member

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@MrHohn
Copy link
Member Author

MrHohn commented May 10, 2019

/retest

1 similar comment
@MrHohn
Copy link
Member Author

MrHohn commented May 10, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5184b86 into kubernetes:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrHohn @yujuhong @k8s-ci-robot @tallclair