Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use e2elog.Logf instead of framework.Logf #77427

Merged
merged 1 commit into from
May 8, 2019
Merged

refactor: use e2elog.Logf instead of framework.Logf #77427

merged 1 commit into from
May 8, 2019

Conversation

draveness
Copy link
Contributor

@draveness draveness commented May 4, 2019 •
edited

/kind cleanup
/priority backlog

What this PR does / why we need it:

Move e2e e2e/ui and e2e/scheduling test to use e2e.Logf

Ref #77359

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 4, 2019
draveness
draveness commented May 4, 2019
View reviewed changes
test/e2e/e2e.go
runKubernetesServiceTestContainer(c, metav1.NamespaceDefault)
framework.Failf("Error waiting for all pods to be running and ready: %v", err)
}

if err := framework.WaitForDaemonSets(c, metav1.NamespaceSystem, int32(framework.TestContext.AllowedNotReadyNodes), framework.TestContext.SystemDaemonsetStartupTimeout); err != nil {
framework.Logf("WARNING: Waiting for all daemonsets to be ready failed: %v", err)
e2elog.Logf("WARNING: Waiting for all daemonsets to be ready failed: %v", err)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim case + 1

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 4, 2019
@draveness draveness force-pushed the feature/use-logf-in-log-pkg branch from c732950 to 7c5f86c Compare May 4, 2019 01:11
@draveness
Copy link
Contributor Author

/assign @andrewsykim @timothysc

bsalamat
bsalamat reviewed May 4, 2019
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a code style comment.

test/e2e/scheduling/taint_based_evictions.go Outdated
@@ -21,7 +21,7 @@ import (
"fmt"
"time"

"k8s.io/api/core/v1"
v1 "k8s.io/api/core/v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this line. There is no need to create an alias here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I revert these changes in this PR. But the v1 prefix is added by goimports which related to #77045 and #77407 :D

Copy link
Member

@timothysc timothysc May 8, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah goimport does this automatically.

test/e2e/scheduling/taints.go Outdated Show resolved Hide resolved
test/e2e/scheduling/ubernetes_lite.go Outdated Show resolved Hide resolved
@draveness draveness force-pushed the feature/use-logf-in-log-pkg branch from 7c5f86c to 6481961 Compare May 4, 2019 01:34
@draveness
Copy link
Contributor Author

/retest

andrewsykim
andrewsykim reviewed May 6, 2019
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

test/e2e/scheduling/taints.go Show resolved Hide resolved
oomichi
oomichi reviewed May 6, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

test/e2e/scheduling/taints.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from oomichi May 6, 2019 17:26
@draveness draveness force-pushed the feature/use-logf-in-log-pkg branch from 6481961 to da75075 Compare May 7, 2019 00:15
@draveness
Copy link
Contributor Author

Done. PTAL :)

oomichi
oomichi reviewed May 7, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating,

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@andrewsykim
Copy link
Member

LGTM as well

/assign @timothysc

bsalamat
bsalamat reviewed May 7, 2019
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

But you need more approvals from other module owners.

timothysc
timothysc approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, draveness, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit f7d92fb into kubernetes:master May 8, 2019
@draveness draveness deleted the feature/use-logf-in-log-pkg branch May 9, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@bsalamat bsalamat bsalamat left review comments

@timothysc timothysc timothysc approved these changes

@sttts sttts Awaiting requested review from sttts

Assignees

@timothysc timothysc

@oomichi oomichi

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@draveness @andrewsykim @k8s-ci-robot @timothysc @oomichi @bsalamat