Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove private copies and update the code to use shared annotations #77443

Merged
merged 1 commit into from
May 7, 2019
Merged

Remove private copies and update the code to use shared annotations #77443

merged 1 commit into from
May 7, 2019

Conversation

cofyc
Copy link
Member

@cofyc cofyc commented May 4, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

  • Share these annotations in multiple packages
  • External applications can reference these constants instead of copying

Which issue(s) this PR fixes:

Fixes #77085

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 4, 2019
@cofyc
Copy link
Member Author

cofyc commented May 4, 2019

/assign @msau42
/assign @jsafrane

@cofyc cofyc changed the title Move all private annotations to shared package and update code Remove private annotations and update the code to use shared annotations May 4, 2019
@cofyc cofyc changed the title Remove private annotations and update the code to use shared annotations Remove private copies and update the code to use shared annotations May 4, 2019
@cofyc
Copy link
Member Author

cofyc commented May 5, 2019

/retest

@msau42
Copy link
Member

msau42 commented May 7, 2019

/lgtm
/approve
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 86a0a3d into kubernetes:master May 7, 2019
@cofyc cofyc deleted the fix77085 branch September 2, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichuqiang lichuqiang Awaiting requested review from lichuqiang

@msau42 msau42 Awaiting requested review from msau42

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow up of #75434: remove duplicate constants
4 participants
@cofyc @msau42 @k8s-ci-robot @jsafrane