Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexport PrintTable function #77530

Merged
merged 1 commit into from
May 9, 2019
Merged

Unexport PrintTable function #77530

merged 1 commit into from
May 9, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented May 7, 2019

  • PrintTable function should not be exported; unexport it
  • Use the exported PrintObj function instead
  • Update expected test strings, since the PrintObj correctly uses a tabwriter

Helps fix:
kubernetes/kubectl#80

NONE

/kind cleanup
/sig cli
/assign

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 7, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 7, 2019
@seans3
Copy link
Contributor Author

seans3 commented May 7, 2019

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 7, 2019
@seans3
Copy link
Contributor Author

seans3 commented May 7, 2019

/assign @liggitt
/assign @soltysh

@liggitt
Copy link
Member

liggitt commented May 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@seans3
Copy link
Contributor Author

seans3 commented May 8, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit b6887e3 into kubernetes:master May 9, 2019
@seans3 seans3 deleted the unexport-print-table branch August 21, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghodss ghodss Awaiting requested review from ghodss

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@soltysh soltysh

@liggitt liggitt

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seans3 @liggitt @k8s-ci-robot @soltysh