Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move GCERegionalPersistentDisk feature from cloud-provider into kube_features.go #77564

Merged
merged 1 commit into from
May 8, 2019
Merged

move GCERegionalPersistentDisk feature from cloud-provider into kube_features.go #77564

merged 1 commit into from
May 8, 2019

Conversation

logicalhan
Copy link
Member

As of #77412, GCERegionalPersistentDisk is no longer used in cloud-provider. This PR removes the string declaration from cloud-provider and declares it directly in kube_features.go.

This change prevents cloud-provider from bringing in apiserver and component-base (and csi-translation-lib from bringing those two things in transitively).

What type of PR is this?

/kind cleanup

NONE

/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 7, 2019
@logicalhan
Copy link
Member Author

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. area/cloudprovider area/dependency Issues or PRs related to dependency changes and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, dchen1107 and a team May 7, 2019 22:59
@logicalhan logicalhan force-pushed the GCERegionalPersistentDisk branch 2 times, most recently from 75f4225 to 2aa0d82 Compare May 7, 2019 23:12
@andrewsykim
Copy link
Member

andrewsykim commented May 7, 2019 •
edited

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@andrewsykim
Copy link
Member

/area code-organization

@k8s-ci-robot k8s-ci-robot added the area/code-organization Issues or PRs related to kubernetes code organization label May 7, 2019
@andrewsykim
Copy link
Member

/assign @dims

@logicalhan
Copy link
Member Author

/test pull-kubernetes-dependencies pull-kubernetes-kubemark-e2e-gce-big

@lavalamp
Copy link
Member

lavalamp commented May 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, lavalamp, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@lavalamp
Copy link
Member

lavalamp commented May 7, 2019

thanks for squashing!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@logicalhan
Copy link
Member Author

/test pull-kubernetes-node-e2e

@logicalhan
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@logicalhan
Copy link
Member Author

/test pull-kubernetes-verify

@logicalhan
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

@logicalhan
remove GCERegionalPersistentDisk feature from cloud-provider directly…
33522a7 
… to pkg/features since it is no longer used in cloud-provider. This change prevents cloud-provider from bringing in apiserver and component-base (and csi-translation-lib from bringing those two things in transitively)
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@liggitt
Copy link
Member

liggitt commented May 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@liggitt
Copy link
Member

liggitt commented May 8, 2019

reported integration flake in #77573

/retest

@logicalhan
Copy link
Member Author

/test pull-kubernetes-integration

2 similar comments
@logicalhan
Copy link
Member Author

/test pull-kubernetes-integration

@logicalhan
Copy link
Member Author

/test pull-kubernetes-integration

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 91528d6 into kubernetes:master May 8, 2019
@logicalhan logicalhan mentioned this pull request May 8, 2019
Merged
@logicalhan logicalhan deleted the GCERegionalPersistentDisk branch May 8, 2019 09:03
@andrewsykim andrewsykim mentioned this pull request May 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@dims dims

@lavalamp lavalamp

@liggitt liggitt

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@logicalhan @andrewsykim @lavalamp @k8s-ci-robot @liggitt @fejta-bot @dims