Impose length limit when concatenating revision history

[tedyu]

What type of PR is this?
/kind bug

What this PR does / why we need it:
As Paul reported, we should impose length limit when concatenating revisions.

Otherwise, we may see the following error:

I0502 01:39:20.871854       6 deployment_controller.go:485] Error syncing deployment yarn-crm/crm-qa-nm: ReplicaSet.apps "crm-qa-nm-7bf7b57dff" is invalid: metadata.annotations: Too long: must have at most 262144 characters

Which issue(s) this PR fixes:
Fixes #77387

NONE

[tedyu]

cc @janetkuo @yastij

[tedyu]

ping @janetkuo for review

[yastij]

/assign @janetkuo

[yastij]

/priority important-soon

[mortent]

This mostly looks good to me. As far as I can tell, this addresses the issue with the length of the annotation growing without bounds. In the issue it was also suggested that we should only add to the revision history if the revision number actually changed (to avoid the 41,41,41... situation). We might want to address that too in this PR.

[tedyu]

@mortent
I modified the condition on line 264:

	if ok && oldRevisionInt < newRevisionInt {

if the above is not enough to prevent duplicate revisions to appear in revision history, please let me know what else needs to change.

Thanks

[mortent]

@tedyu When I'm looking at it now, I think you are right. It should be covered by your change.

/lgtm

[tedyu]

ping @janetkuo

[janetkuo]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/deployment/OWNERS [janetkuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment