Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use framework.ExpectNoError instead #77627

Merged
merged 1 commit into from
May 14, 2019
Merged

refactor: use framework.ExpectNoError instead #77627

merged 1 commit into from
May 14, 2019
+14 −19

Conversation

draveness
Copy link
Contributor

What type of PR is this?
/kind cleanup
/priority backlog
/sig testing

What this PR does / why we need it:

Ref: #77103

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/test labels May 9, 2019
@draveness draveness force-pushed the feature/refactor-expect-no-error branch from 47c7e54 to a04db52 Compare May 9, 2019 01:56
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2019
@draveness
Copy link
Contributor Author

/assign @oomichi @timothysc @shyamjvs

oomichi
oomichi reviewed May 9, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@draveness Thank you so much for this work!

/lgtm

test/e2e/upgrades/apps/statefulset.go
@@ -18,7 +18,6 @@ package upgrades

import (
"github.com/onsi/ginkgo"
"github.com/onsi/gomega"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love to see this removal :-)

test/e2e/upgrades/storage/persistent_volumes.go
@@ -23,7 +23,6 @@ import (
"k8s.io/kubernetes/test/e2e/framework/volume"

"github.com/onsi/ginkgo"
"github.com/onsi/gomega"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@draveness draveness mentioned this pull request May 9, 2019
Closed
23 tasks
@draveness draveness force-pushed the feature/refactor-expect-no-error branch from a04db52 to 083f95d Compare May 11, 2019 12:00
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2019
@draveness
Copy link
Contributor Author

@oomichi Rebased, PTAL : D

oomichi
oomichi reviewed May 11, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 11, 2019
@draveness draveness force-pushed the feature/refactor-expect-no-error branch from 2940847 to 083f95d Compare May 12, 2019 00:33
@draveness
Copy link
Contributor Author

/test pull-kubernetes-integration

@draveness draveness force-pushed the feature/refactor-expect-no-error branch from 083f95d to 950f6e8 Compare May 12, 2019 02:44
@oomichi
Copy link
Member

oomichi commented May 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@timothysc timothysc added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 13, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 13, 2019
timothysc
timothysc approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thx @draveness !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@oomichi
Copy link
Member

oomichi commented May 13, 2019

The old job viewer, Gubernator, has been deprecated in favour of this page, Spyglass. For now, the old page is still available. Please send feedback to sig-testing. on the job dashboard. Let's retry.

/retest

@k8s-ci-robot k8s-ci-robot merged commit cf8e8e4 into kubernetes:master May 14, 2019
@draveness draveness deleted the feature/refactor-expect-no-error branch July 1, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@timothysc timothysc timothysc approved these changes

@foxish foxish Awaiting requested review from foxish

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@timothysc timothysc

@oomichi oomichi

@shyamjvs shyamjvs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@draveness @oomichi @k8s-ci-robot @timothysc @shyamjvs