Fix golint failures of e2e/framework/*.go #77643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
spiffxp
suggested changes
May 9, 2019
atoato88
force-pushed
the
fix-golint-e2e-framework-asterisk
branch
from
bc6eed2
to
cd58b35
Compare
oomichi
reviewed
May 9, 2019
atoato88
force-pushed
the
fix-golint-e2e-framework-asterisk
branch
from
cd58b35
to
726dbdd
Compare
|
/test pull-kubernetes-verify |
k8s-ci-robot
added
the
lgtm
|
/priority important-longterm |
k8s-ci-robot
added
priority/important-longterm
|
/approve |
|
@spiffxp Is it still necessary to be marked as "requested changes "? |
spiffxp
reviewed
May 11, 2019
|
One typo remaining otherwise looks good. I guess I can get onboard with not renaming the methods if we're just trying to be mechanical about this. |
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
This fixes golint failures of the following files: - test/e2e/framework/networking_utils.go - test/e2e/framework/service_util.go - test/e2e/framework/util.go All golint failures in test/e2e/framework are fixed at this commit. Remove 'test/e2e/framework' from 'hack/.golint_failures'
atoato88
force-pushed
the
fix-golint-e2e-framework-asterisk
branch
from
726dbdd
to
dddc6a5
Compare
|
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atoato88, oomichi, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/kind cleanup |
|
/kind cleanup cancel |
|
/kind cleanup |
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
/kind bug cancel |
|
/remove-kind bug |
|
@nikhita Thanks for doing that, that was what I wanted to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This fixes golint failures of the following files:
All golint failures in test/e2e/framework are fixed at this commit.
Remove 'test/e2e/framework' from 'hack/.golint_failures'.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Ref: #68026