-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pending status for pastBackoffLimitOnFailure #77647
Conversation
/priority important-soon |
@fisherxu good catch. Thank you for fixing it! Would you add a test to catch this? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu, janetkuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sure, will add it. |
@janetkuo have add the test and passed, ptal |
We try to avoid having approver to lgtm a PR so that we have at least two sets of eyes on a PR. @mortent would you help review this? |
@fisherxu This looks good to me. Can you squash the commits before we merge it? |
/lgtm |
/test pull-kubernetes-kubemark-e2e-gce-big |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Set Job failed when initcontainer restart count to backoffLimit
Which issue(s) this PR fixes:
Fixes #77644
Special notes for your reviewer:
Does this PR introduce a user-facing change?: