Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending status for pastBackoffLimitOnFailure #77647

Merged
merged 1 commit into from
May 21, 2019

Conversation

fisherxu
Copy link
Contributor

@fisherxu fisherxu commented May 9, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Set Job failed when initcontainer restart count to backoffLimit

Which issue(s) this PR fixes:

Fixes #77644

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 9, 2019
@fisherxu
Copy link
Contributor Author

fisherxu commented May 9, 2019

/assign @janetkuo @soltysh

@fisherxu
Copy link
Contributor Author

/priority important-soon
@kubernetes/sig-apps-pr-reviews needs comments here

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 15, 2019
@janetkuo
Copy link
Member

@fisherxu good catch. Thank you for fixing it! Would you add a test to catch this?

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@fisherxu
Copy link
Contributor Author

Would you add a test to catch this?

Sure, will add it.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2019
@fisherxu
Copy link
Contributor Author

@janetkuo have add the test and passed, ptal

@janetkuo
Copy link
Member

We try to avoid having approver to lgtm a PR so that we have at least two sets of eyes on a PR.

@mortent would you help review this?

@mortent
Copy link
Member

mortent commented May 20, 2019

@fisherxu This looks good to me. Can you squash the commits before we merge it?

@fisherxu
Copy link
Contributor Author

Can you squash the commits before we merge it?

@janetkuo @mortent have done.

@mortent
Copy link
Member

mortent commented May 21, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2019
@fisherxu
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InitContainer exec failed when job-pod start, the Restartcount can't used for backoffLimit
5 participants