Fix golint failures of test/e2e/network #77668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/assign @fejta |
spiffxp
suggested changes
May 11, 2019
test/e2e/network/no_snat.go
Outdated
| . "github.com/onsi/ginkgo" | ||
| // . "github.com/onsi/gomega" | ||
| "github.com/onsi/ginkgo" | ||
| // "github.com/onsi/gomega" |
There was a problem hiding this comment.
I would prefer we remove this instead of leaving it commented out
test/e2e/network/util_iperf.go
Outdated
| @@ -101,7 +103,7 @@ func (s StrSlice) get(i int) string { | |||
| func intOrFail(debugName string, rawValue string) int64 { | |||
| value, err := strconv.ParseInt(rawValue, 10, 64) | |||
| if err != nil { | |||
| framework.Failf("Failed parsing value %v from the string '%v' as an integer", debugName, rawValue) | |||
| framework.Failf("ginkgo.Failed parsing value %v from the string '%v' as an integer", debugName, rawValue) | |||
There was a problem hiding this comment.
Suggested change
| framework.Failf("ginkgo.Failed parsing value %v from the string '%v' as an integer", debugName, rawValue) | |
| framework.Failf("Failed parsing value %v from the string '%v' as an integer", debugName, rawValue) |
There was a problem hiding this comment.
Thanks a lot 👍
I've updated the code.
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
SataQiu
force-pushed
the
fix-golint-test-20190509
branch
from
c5bee8a
to
40913af
Compare
SataQiu
force-pushed
the
fix-golint-test-20190509
branch
from
40913af
to
515f834
Compare
spiffxp
approved these changes
May 11, 2019
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SataQiu, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest Review the full test history for this PR. Silence the bot with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix golint failures of test/e2e/network
Which issue(s) this PR fixes:
Ref #68026
Special notes for your reviewer:
Does this PR introduce a user-facing change?: