Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use framework.ExpectNoError instead in e2e test #77708

Merged
merged 1 commit into from
May 11, 2019
Merged

feat: use framework.ExpectNoError instead in e2e test #77708

merged 1 commit into from
May 11, 2019

Conversation

draveness
Copy link
Contributor

/kind cleanup
/priority backlog
/sig testing

What this PR does / why we need it:

ref: #77103

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 10, 2019
@draveness
Copy link
Contributor Author

/cc @oomichi

@k8s-ci-robot k8s-ci-robot requested a review from oomichi May 10, 2019 01:35
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label May 10, 2019
@draveness draveness mentioned this pull request May 10, 2019
Closed
23 tasks
@draveness draveness force-pushed the feature/refactor-more-expectnoerror-in-e2e branch from f417a2a to c045046 Compare May 10, 2019 01:53
@oomichi
Copy link
Member

oomichi commented May 10, 2019

@draveness Thanks for doing this.
We just need to remove the following lines for passing CI jobs:

/b/f/w/test/e2e/apimachinery/crd_watch.go:34:2: imported and not used: "k8s.io/kubernetes/vendor/github.com/onsi/gomega"
/b/f/w/test/e2e/apimachinery/garbage_collector.go:45:2: imported and not used: "k8s.io/kubernetes/vendor/github.com/onsi/gomega"
/b/f/w/test/e2e/apimachinery/watch.go:33:2: imported and not used: "k8s.io/kubernetes/vendor/github.com/onsi/gomega"

I much prefer to see such gomega removals anyways :-)

@draveness
Copy link
Contributor Author

/assign @timothysc @deads2k

neolit123
neolit123 reviewed May 10, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2019
@oomichi
Copy link
Member

oomichi commented May 10, 2019

much better, thanks

/lgtm

@oomichi
Copy link
Member

oomichi commented May 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2019
@draveness
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6897c68 into kubernetes:master May 11, 2019
@draveness draveness deleted the feature/refactor-more-expectnoerror-in-e2e branch July 1, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@foxish foxish Awaiting requested review from foxish

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@timothysc timothysc

@neolit123 neolit123

@oomichi oomichi

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@draveness @oomichi @k8s-ci-robot @neolit123 @timothysc @deads2k