Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix golint error make test error checking more readable in test/e2e/node #77715

Merged
merged 3 commits into from
May 14, 2019
Merged

fix golint error make test error checking more readable in test/e2e/node #77715

merged 3 commits into from
May 14, 2019

Conversation

danielqsj
Copy link
Contributor

@danielqsj danielqsj commented May 10, 2019 •
edited

What type of PR is this?

/kind cleanup
/sig testing

What this PR does / why we need it:

in test/e2e/node:

  1. fix golint error
  2. make test error checking more readable

Which issue(s) this PR fixes:

Part of #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test labels May 10, 2019
@danielqsj
Copy link
Contributor Author

/assign @oomichi

@danielqsj danielqsj mentioned this pull request May 10, 2019
Closed
21 tasks
@danielqsj
Copy link
Contributor Author

/retest

@danielqsj
Copy link
Contributor Author

/cc @BenTheElder @fejta

@oomichi
Copy link
Member

oomichi commented May 10, 2019

This is a port of #68026 not #77706

Please fix the PR message for the reference.

@spiffxp
Copy link
Member

spiffxp commented May 11, 2019

/hold
Please address @oomichi's concern, otherwise this looks good
/priority backlog

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 11, 2019
@danielqsj
Copy link
Contributor Author

/retest

@danielqsj
Copy link
Contributor Author

This should be a part of #68026 not #77706

Addressed. Thanks.

@danielqsj
Copy link
Contributor Author

/retest

@SataQiu
Copy link
Member

SataQiu commented May 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2019
@oomichi
Copy link
Member

oomichi commented May 13, 2019

/lgtm
/approve

@spiffxp
Copy link
Member

spiffxp commented May 14, 2019

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielqsj, oomichi, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit a60d212 into kubernetes:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

@tallclair tallclair Awaiting requested review from tallclair

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@fejta fejta Awaiting requested review from fejta

Assignees

@oomichi oomichi

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danielqsj @oomichi @spiffxp @SataQiu @k8s-ci-robot