Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bazel-toolschains for bazel <= 0.25.2 rbe support #77853

Merged
merged 1 commit into from May 15, 2019
Merged

Update bazel-toolschains for bazel <= 0.25.2 rbe support #77853

merged 1 commit into from May 15, 2019

Conversation

fejta
Copy link
Contributor

@fejta fejta commented May 14, 2019 •
edited

/sig testing
/kind cleanup

latest available at https://github.com/bazelbuild/bazel-toolchains/releases

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 14, 2019
@fejta fejta added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/flake Categorizes issue or PR as related to a flaky test. labels May 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@fejta
Copy link
Contributor Author

fejta commented May 14, 2019

/assign @mikedanese @BenTheElder

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2019
@fejta fejta changed the title Update bazel-toolschains for bazel <= 0.25.1 rbe support Update bazel-toolschains for bazel <= 0.25.2 rbe support May 14, 2019
@fejta
Copy link
Contributor Author

fejta commented May 14, 2019

/test pull-kubernetes-e2e-gce

@fejta
Copy link
Contributor Author

fejta commented May 14, 2019

Ben are you meaning to /lgtm?

@BenTheElder
Copy link
Member

we should unify that 🤦‍♂️
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2019
@spiffxp
Copy link
Member

spiffxp commented May 14, 2019

/lgtm

@fejta
Copy link
Contributor Author

fejta commented May 14, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit b066e0d into kubernetes:master May 15, 2019
@fejta fejta mentioned this pull request May 15, 2019
Merged
@yue9944882 yue9944882 mentioned this pull request May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@jbeda jbeda Awaiting requested review from jbeda

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@spiffxp spiffxp

@BenTheElder BenTheElder

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fejta @k8s-ci-robot @BenTheElder @spiffxp @mikedanese