Use ExpectNoError() for scalability and scheduling #77890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
23 tasks
k8s-ci-robot
added
area/test
sig/testing
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kubernetes-node-e2e |
|
/test pull-kubernetes-e2e-gce-100-performance |
|
/priority backlog |
k8s-ci-robot
added
priority/backlog
|
/retest |
oomichi
force-pushed
the
use-ExpectNoError-scalability
branch
from
b2c6dc5
to
a18d8f1
Compare
The e2e test framework has ExpectNoError() for readable test code. This replaces Expect(err).NotTo(HaveOccurred()) with it.
oomichi
force-pushed
the
use-ExpectNoError-scalability
branch
from
a18d8f1
to
48f1f74
Compare
|
@timothysc @neolit123 Could you take a look at this? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@neolit123 Thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The e2e test framework has ExpectNoError() for readable test code.
This replaces Expect(err).NotTo(HaveOccurred()) with it.
ref: #77103
Does this PR introduce a user-facing change?: