Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use framework.ExpectNoError in e2e apps disruption #77894

Merged
merged 1 commit into from
May 16, 2019
Merged

feat: use framework.ExpectNoError in e2e apps disruption #77894

merged 1 commit into from
May 16, 2019

Conversation

draveness
Copy link
Contributor

/kind cleanup
/priority backlog
/sig testing
/cc @oomichi

What this PR does / why we need it:

use framework.ExpectNoError in apps and upgrades pkg

ref: #77103

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 15, 2019
@k8s-ci-robot k8s-ci-robot requested a review from oomichi May 15, 2019 02:10
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 15, 2019
@draveness draveness changed the title feat: use framework.ExpectNoError in ese apps disruption feat: use framework.ExpectNoError in e2e apps disruption May 15, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels May 15, 2019
@draveness draveness force-pushed the feature/refactor-test-e2e-apps branch from 32ee98b to 95a6376 Compare May 15, 2019 02:11
@oomichi
Copy link
Member

oomichi commented May 15, 2019

Thanks for doing this.

/assign

@oomichi oomichi mentioned this pull request May 15, 2019
Closed
23 tasks
@xichengliudui
Copy link
Contributor

/test pull-kubernetes-e2e-gce-device-plugin-gpu
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 15, 2019
@xichengliudui
Copy link
Contributor

/retest

@oomichi
Copy link
Member

oomichi commented May 15, 2019

Thanks again.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1284c99 into kubernetes:master May 16, 2019
@draveness draveness deleted the feature/refactor-test-e2e-apps branch May 16, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@draveness @oomichi @xichengliudui @k8s-ci-robot