Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use framework.ExpectNoError() for e2e/network #77901

Merged
merged 1 commit into from
May 18, 2019
Merged

use framework.ExpectNoError() for e2e/network #77901

merged 1 commit into from
May 18, 2019

Conversation

k-toyoda-pi
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The e2e test framework has ExpectNoError() for readable test code.
This replaces gomega.Expect(err).NotTo(gomega.HaveOccurred()) with it for e2e/network.

  • test/e2e/network/dns.go
  • test/e2e/network/dns_common.go
  • test/e2e/network/example_cluster_dns.go
  • test/e2e/network/firewall.go
  • test/e2e/network/network_policy.go
  • test/e2e/network/network_tiers.go
  • test/e2e/network/proxy.go

Which issue(s) this PR fixes:
Ref #77103

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @k-toyoda-pi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 15, 2019
@dcbw
Copy link
Member

dcbw commented May 15, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2019
@k-toyoda-pi
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@draveness
Copy link
Contributor

/retest

@draveness
Copy link
Contributor

cc/ @oomichi

@oomichi
Copy link
Member

oomichi commented May 15, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2019
@k-toyoda-pi
Copy link
Contributor Author

/assign @thockin
for approval

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k-toyoda-pi, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2019
@oomichi
Copy link
Member

oomichi commented May 16, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

2 similar comments
@oomichi
Copy link
Member

oomichi commented May 16, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@oomichi
Copy link
Member

oomichi commented May 16, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@k-toyoda-pi
Copy link
Contributor Author

/test pull-kubernetes-integration

1 similar comment
@k-toyoda-pi
Copy link
Contributor Author

/test pull-kubernetes-integration

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@oomichi
Copy link
Member

oomichi commented May 17, 2019

/test pull-kubernetes-integration

@oomichi
Copy link
Member

oomichi commented May 17, 2019

/test pull-kubernetes-e2e-gce-100-performance

2 similar comments
@oomichi
Copy link
Member

oomichi commented May 17, 2019

/test pull-kubernetes-e2e-gce-100-performance

@oomichi
Copy link
Member

oomichi commented May 17, 2019

/test pull-kubernetes-e2e-gce-100-performance

@k8s-ci-robot k8s-ci-robot merged commit a7f13bc into kubernetes:master May 18, 2019
@k8s-ci-robot
Copy link
Contributor

@k-toyoda-pi: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce ba4119a link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k-toyoda-pi k-toyoda-pi deleted the use_expect_no_error_e2e_network_1 branch May 20, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants