-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hack/lib/golang.sh for bash 4.3 #77910
Conversation
/test pull-kubernetes-e2e-gce |
/test pull-kubernetes-integration |
w00t interesting! thanks for taking this on @adisky |
@dims Tried fixing the scope resolution problem for readonly variable for bash version 4.3, tested the above changes on bash 4.4, trying to get it tested on 4.3 |
Thanks @adisky , it's working for me now |
/sig release |
/priority critical-urgent |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adisky, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This has broken MacOS build:
|
This discussion seems related https://discuss.kubernetes.io/t/help-wanted-role-build-and-shell-cleanup/6064/10 , is it failing with the default bash version on Mac? version 3? |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes compatibiltiy issue with bash version 4.3 for script hack/lib/golang.sh, to solve the scope issue of
readonly
variables in both version 4.3 and 4.4, required variables are declared usingdeclare -g
Which issue(s) this PR fixes:
Fixes #77521
Special notes for your reviewer:
Does this PR introduce a user-facing change?: