Upload kubeconfig to master metadata in tests. #77930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel Should be good now. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Once this is in, kubeconfig will be accessible via cloud ui or gcloud command |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Till a few days ago, it was possible to ssh into master and access cluster via insecure master port. Now, the master insecure port has been disabled, we're not able to do that anymore. This PR aims to fix that by uploading the kubeconfig to the master metadata during cluster setup in tests.
|
This feels a little gross, but is probably fine to do for tests. /lgtm |
k8s-ci-robot
added
the
lgtm
|
Given lgtm from security side, I'm approving this one. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Till a few days ago, it was possible to ssh into master and access cluster via insecure master port.
Now, the master insecure port has been disabled, we're not able to do that anymore.
This PR aims to fix that by uploading the kubeconfig to the master metadata during cluster setup in tests.
Does this PR introduce a user-facing change?: