Code cleanup for for probe/http #78031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
mattjmcnaughton
force-pushed
the
mattjmcnaughton/cleanup-probe-http
branch
from
56f373e
to
0a50d1d
Compare
|
On Fri, May 17, 2019 at 07:23:23AM -0700, Kubernetes Prow Robot wrote:
[APPROVALNOTIFIER] This PR is **NOT APPROVED**
This pull-request has been approved by: *<a href="#78031#" title="Author self-approved">mattjmcnaughton</a>*
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: **dchen1107**
If they are not already assigned, you can assign the PR to them by writing `/assign @dchen1107` in a comment when ready.
The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).
The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)
<details open>
Needs approval from an approver in each of these files:
- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**
- **[pkg/probe/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/probe/OWNERS)**
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["dchen1107"]} -->
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#78031 (comment)
/assign @dchen1107
thanks :)
|
|
cc @dchen1107 mind approving when you have a sec? thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattjmcnaughton, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Two small code cleanup changes for `probe/http`. - Tests name the `followNonLocalRedirects` variable before passing to `New`, so its clear what the boolean flag in the construct impacts. - Change import name from `httprobe` to `httpprobe` when used by `pkg/kubelet/prober/prober.go`. Establishes consistency with other uses in the repo.
mattjmcnaughton
force-pushed
the
mattjmcnaughton/cleanup-probe-http
branch
from
0a50d1d
to
4626775
Compare
k8s-ci-robot
removed
the
lgtm
|
cc @tallclair mind approving again after rebase? thanks! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Two small code cleanup changes for
probe/http.followNonLocalRedirectsvariable before passing toNew, so its clear what the boolean flag in the construct impacts.httprobetohttpprobewhen used bypkg/kubelet/prober/prober.go. Establishes consistency with other usesin the repo.
Does this PR introduce a user-facing change?: