Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: fix CreateMultiVersionTestCRD version logic #78131

Merged
merged 1 commit into from
May 21, 2019
Merged

e2e: fix CreateMultiVersionTestCRD version logic #78131

merged 1 commit into from
May 21, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 20, 2019 •
edited by liggitt

The code didn't store the CRD versions in the CRD object.

Fixes #78087

NONE

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 20, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 20, 2019
@sttts sttts force-pushed the sttts-e2e-CreateMultiVersionTestCRD-fix branch from 0e2111a to 710d3c9 Compare May 20, 2019 19:59
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2019
@sttts sttts force-pushed the sttts-e2e-CreateMultiVersionTestCRD-fix branch 2 times, most recently from c8e2f05 to d07f1b8 Compare May 20, 2019 20:01
@sttts
Copy link
Contributor Author

sttts commented May 20, 2019

/assign @liggitt

@sttts sttts force-pushed the sttts-e2e-CreateMultiVersionTestCRD-fix branch from d07f1b8 to 9e04e77 Compare May 20, 2019 20:07
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 20, 2019
@liggitt
Copy link
Member

liggitt commented May 20, 2019

/kind bug
/priority critical-urgent
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor Author

sttts commented May 20, 2019

/retest

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 20, 2019
@sttts
Copy link
Contributor Author

sttts commented May 20, 2019

/retest

bazel broken?

@liggitt
Copy link
Member

liggitt commented May 20, 2019

#74931 flake

/retest

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 20, 2019
@liggitt
Copy link
Member

liggitt commented May 20, 2019

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit fe0d89f into kubernetes:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@pwittrock pwittrock Awaiting requested review from pwittrock

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failing tests] CustomResourceConversionWebhook and CustomResourcePublishOpenAPI failing in master-blocking
3 participants
@sttts @liggitt @k8s-ci-robot