Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BeTrue to Equal/BeNumerically in cronjob e2e test #78277

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Change BeTrue to Equal/BeNumerically in cronjob e2e test #78277

merged 1 commit into from
Jun 17, 2019

Conversation

k-toyoda-pi
Copy link
Contributor

@k-toyoda-pi k-toyoda-pi commented May 24, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
cronjob e2e test contains like gomega.Expect(len(finishedJobs) == 1).To(gomega.BeTrue()).
When the test fails, the following result is output. From the result, it is difficult to understand what happens.

  Expected
      <bool>: false
  to be true

This PR changes to use Equal or BeNumerically function and the result is changed to the following message. We can get more information from that when test fails.

  Expected
      <int>: 2
  to equal
      <int>: 1

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/sig apps
/sig testing

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @k-toyoda-pi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mortent
Copy link
Member

mortent commented May 29, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2019
@mortent
Copy link
Member

mortent commented May 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@k-toyoda-pi
Copy link
Contributor Author

/test pull-kubernetes-typecheck
/test pull-kubernetes-integration

@k-toyoda-pi
Copy link
Contributor Author

/assign @mfojtik
Could you review and approve?

@k-toyoda-pi
Copy link
Contributor Author

/assign @Kargakis
for approval

Copy link
Contributor

@0xmichalis 0xmichalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k-toyoda-pi, kargakis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8f927d8 into kubernetes:master Jun 17, 2019
@k-toyoda-pi k-toyoda-pi deleted the change_betrue_equal_for_cronjob_test branch June 17, 2019 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants