Runtimeclass admission #78484

egernst · 2019-05-29T16:17:13Z

/kind feature
What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

(captured by #76968)

Introduce a new admission controller for RuntimeClass. Initially, RuntimeClass will be used to apply the pod overhead associated with a given RuntimeClass to the Pod.Spec if a corresponding RuntimeClassName is specified.

PodOverhead is an alpha feature as of Kubernetes 1.16.

Depends on:
#76968

fejta-bot · 2019-05-29T17:30:17Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

yue9944882

left some review comments under package plugin/pkg/admission/...

plugin/pkg/admission/runtimeclass/admission.go

yue9944882 · 2019-05-31T06:11:48Z

plugin/pkg/admission/runtimeclass/admission.go

+		}
+
+	default:
+		return fmt.Errorf("invalid value for admissionPhase: %s", admissionPhase)


nit: admissionPhase sounds a bit odd to me. the mutating and validating logic should better be separated i suppose? ping @liggitt for suggestions.

Yeah, names are hard. I wanted to deduplicate some of the boiler plate handling that is needed for both mutation and validation phases of the controller. Happy to hear better suggestions for the name.

optional: Alternatively, just put the boilerplate in a helper:

pod, runtimeClass, err := r.prepareObjects(attributes)

(needs a better name though)

Updated to add the helper. I named it prepareObjects, but am going to go for a two hour bike ride this evening and think of a more appropriate name.

fedebongio · 2019-05-31T20:12:43Z

/remove-sig api-machinery

yastij · 2019-06-12T08:16:05Z

/assign @tallclair @yastij

egernst · 2019-06-20T00:13:26Z

ack. updated. Thanks Tim.

Signed-off-by: Eric Ernst <eric.ernst@intel.com>

tallclair · 2019-06-27T21:22:27Z

Can you add an OWNERS file to the new admission controller. Approver should be me, and you can add yourself as a reviewer :)

tallclair · 2019-06-27T21:23:18Z

/lgtm

egernst · 2019-06-27T22:53:10Z

added owners file

add initial owners file for RuntimeClass admission controller Signed-off-by: Eric Ernst <eric.ernst@intel.com>

tallclair · 2019-06-27T23:29:13Z

/lgtm
/approve

yastij

/lgtm

tallclair · 2019-06-28T19:51:56Z

plugin/pkg/admission/runtimeclass/admission.go

+	}
+}
+
+// admissionAction handles Admit and Validate phases of admission, switching based on the admissionPhase parameter


Comment needs fixing

tallclair · 2019-06-28T19:54:30Z

plugin/pkg/admission/runtimeclass/admission.go

+
+// getRuntimeClass will return a reference to the RuntimeClass object if it is found. If it cannot be found, or a RuntimeClassName
+// is not provided in the pod spec, *node.RuntimeClass returned will be nil
+func (r *RuntimeClass) getRuntimeClass(pod *api.Pod, runtimeClassName *string) (runtimeClass *v1beta1.RuntimeClass, err error) {


pod argument is unused

nit: this is only called from prepare objects, so I'd just inline it.

Handled in my PR #79565.

tallclair · 2019-06-28T19:55:34Z

plugin/pkg/admission/runtimeclass/admission.go

+
+func setOverhead(a admission.Attributes, pod *api.Pod, runtimeClass *v1beta1.RuntimeClass) (err error) {
+
+	if runtimeClass != nil {


nit: prefer:

Suggested change

if runtimeClass != nil {

if runtimeClass == nil || runtimeclass.Overhead == nil {

return nil

}

// ...

tallclair · 2019-06-28T20:06:50Z

/unassign @thockin
/assign @dchen1107

dchen1107 · 2019-06-28T20:09:03Z

/approve

k8s-ci-robot · 2019-06-28T20:09:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, egernst, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/kubeapiserver/OWNERS~~ [dchen1107]
~~plugin/OWNERS~~ [dchen1107]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fejta-bot · 2019-06-29T01:03:13Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot · 2019-06-29T04:54:11Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

tedyu · 2019-06-29T18:58:46Z

plugin/pkg/admission/runtimeclass/admission.go

+		return err
+	}
+
+	if utilfeature.DefaultFeatureGate.Enabled(features.PodOverhead) {


I think this should be moved ahead of call to prepareObjects.
If the feature gate is disabled, pod, runtimeClass would not be used.

tedyu · 2019-06-29T19:09:47Z

plugin/pkg/admission/runtimeclass/admission.go

+
+// getRuntimeClass will return a reference to the RuntimeClass object if it is found. If it cannot be found, or a RuntimeClassName
+// is not provided in the pod spec, *node.RuntimeClass returned will be nil
+func (r *RuntimeClass) getRuntimeClass(pod *api.Pod, runtimeClassName *string) (runtimeClass *v1beta1.RuntimeClass, err error) {


Handled in my PR #79565.

k8s-ci-robot requested review from brendandburns and cheftako May 29, 2019 16:18

egernst mentioned this pull request May 30, 2019

Pod Overhead: account resources tied to the pod sandbox, but not specific containers kubernetes/enhancements#688

Closed

yue9944882 reviewed May 31, 2019

View reviewed changes

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 31, 2019

egernst force-pushed the runtimeclass-admission branch from b7cbeaa to 3c91769 Compare June 7, 2019 00:13

k8s-ci-robot assigned tallclair and yastij Jun 12, 2019

k8s-ci-robot assigned thockin Jun 20, 2019

egernst force-pushed the runtimeclass-admission branch from a637305 to e860830 Compare June 20, 2019 00:12

Eric Ernst added 3 commits June 19, 2019 17:20

introduce RuntimeClass admission controller

247dab3

Signed-off-by: Eric Ernst <eric.ernst@intel.com>

add RuntimeClass admission controller plugin

2d32634

Signed-off-by: Eric Ernst <eric.ernst@intel.com>

autogenerated code update based in new plugin

e860830

Signed-off-by: Eric Ernst <eric.ernst@intel.com>

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 27, 2019

runtimeclass-admissioN: add owners file

824a9e5

add initial owners file for RuntimeClass admission controller Signed-off-by: Eric Ernst <eric.ernst@intel.com>

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019

yastij approved these changes Jun 28, 2019

View reviewed changes

tallclair reviewed Jun 28, 2019

View reviewed changes

k8s-ci-robot assigned dchen1107 and unassigned thockin Jun 28, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2019

k8s-ci-robot merged commit e4f1588 into kubernetes:master Jun 29, 2019

tedyu reviewed Jun 29, 2019

View reviewed changes

tedyu mentioned this pull request Jun 29, 2019

Return the error from validateOverhead in RuntimeClass#Validate #79565

Merged

liggitt added this to the v1.16 milestone Aug 6, 2019

liangxianlong mentioned this pull request Sep 24, 2019

How to use pod overhead in runtimeclass #83054

Closed

tzifudzi mentioned this pull request Nov 29, 2023

[EKS] [request]: vpc-resource-controller does not support .spec.runtimeClassName aws/containers-roadmap#1106

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Runtimeclass admission #78484

Runtimeclass admission #78484

egernst commented May 29, 2019 •

edited

fejta-bot commented May 29, 2019

yue9944882 left a comment

yue9944882 May 31, 2019

egernst Jun 5, 2019

tallclair Jun 14, 2019

egernst Jun 17, 2019

fedebongio commented May 31, 2019

yastij commented Jun 12, 2019

egernst commented Jun 20, 2019

tallclair commented Jun 27, 2019

tallclair commented Jun 27, 2019

egernst commented Jun 27, 2019

tallclair commented Jun 27, 2019

yastij left a comment

tallclair Jun 28, 2019

tallclair Jun 28, 2019

tedyu Jun 29, 2019 •

edited

tallclair Jun 28, 2019

tallclair commented Jun 28, 2019

dchen1107 commented Jun 28, 2019

k8s-ci-robot commented Jun 28, 2019

fejta-bot commented Jun 29, 2019

fejta-bot commented Jun 29, 2019

tedyu Jun 29, 2019

tedyu Jun 29, 2019 •

edited


		func setOverhead(a admission.Attributes, pod api.Pod, runtimeClass v1beta1.RuntimeClass) (err error) {

		if runtimeClass != nil {

-	if runtimeClass != nil {
+if runtimeClass == nil || runtimeclass.Overhead == nil {
+  return nil
+}
+// ...

Runtimeclass admission #78484

Runtimeclass admission #78484

Conversation

egernst commented May 29, 2019 • edited

fejta-bot commented May 29, 2019

yue9944882 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedebongio commented May 31, 2019

yastij commented Jun 12, 2019

egernst commented Jun 20, 2019

tallclair commented Jun 27, 2019

tallclair commented Jun 27, 2019

egernst commented Jun 27, 2019

tallclair commented Jun 27, 2019

yastij left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tedyu Jun 29, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tallclair commented Jun 28, 2019

dchen1107 commented Jun 28, 2019

k8s-ci-robot commented Jun 28, 2019

fejta-bot commented Jun 29, 2019

fejta-bot commented Jun 29, 2019

Choose a reason for hiding this comment

tedyu Jun 29, 2019 • edited

Choose a reason for hiding this comment

egernst commented May 29, 2019 •

edited

tedyu Jun 29, 2019 •

edited

tedyu Jun 29, 2019 •

edited