Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort kubeadm CLI default params for component config API objects #78695

Conversation

dims
Copy link
Member

@dims dims commented Jun 4, 2019

See problem reported here : #70131 (comment) We need to keep the list sorted.

Change-Id: If4ba57d528f925de9d536b18c0e6d71fc6d63659

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Change-Id: If4ba57d528f925de9d536b18c0e6d71fc6d63659
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 4, 2019
@dims dims mentioned this pull request Jun 4, 2019
@k8s-ci-robot k8s-ci-robot requested review from liztio and rosti June 4, 2019 14:17
@dims
Copy link
Member Author

dims commented Jun 4, 2019

/priority important-soon
/assign @neolit123 @fabriziopandini

@k8s-ci-robot k8s-ci-robot added area/kubeadm priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 4, 2019
@dims
Copy link
Member Author

dims commented Jun 4, 2019

/sig cluster-lifecycle
/priority important-soon

@neolit123
Copy link
Member

thanks @dims
/assign @rosti
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jun 4, 2019
Copy link
Contributor

@bmwiedemann bmwiedemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change (rebased on top of openSUSE's kubernetes-1.14.1) and the man page diffs went away.

@bmwiedemann
Copy link
Contributor

The commit message and PR description should add some detail about why this change is good, e.g.:
make the man-page generation reproducible

Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dims !
Just a minor nit, can you add a comment next to the sort call to indicate, that we need it for reproducible builds? Someone may accidentally delete it in the future.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2019
@neolit123
Copy link
Member

neolit123 commented Jun 14, 2019

/lgtm
/hold

@dims @rosti it's OK without the comment, but it's better with it, i guess.

Thanks @dims !
Just a minor nit, can you add a comment next to the sort call to indicate, that we need it for reproducible builds? Someone may accidentally delete it in the future.

@rosti please unhold if see fit.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 14, 2019
@rosti
Copy link
Contributor

rosti commented Jun 17, 2019

Let's not hold it off further, because of the comment.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1b6189e into kubernetes:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants