-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort kubeadm CLI default params for component config API objects #78695
Sort kubeadm CLI default params for component config API objects #78695
Conversation
Change-Id: If4ba57d528f925de9d536b18c0e6d71fc6d63659
/priority important-soon |
/sig cluster-lifecycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this change (rebased on top of openSUSE's kubernetes-1.14.1) and the man page diffs went away.
The commit message and PR description should add some detail about why this change is good, e.g.: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dims !
Just a minor nit, can you add a comment next to the sort call to indicate, that we need it for reproducible builds? Someone may accidentally delete it in the future.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, rosti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm @dims @rosti it's OK without the comment, but it's better with it, i guess.
@rosti please unhold if see fit. |
Let's not hold it off further, because of the comment. |
See problem reported here : #70131 (comment) We need to keep the list sorted.
Change-Id: If4ba57d528f925de9d536b18c0e6d71fc6d63659
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: