-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] Make meaningful service name in test #78703
Conversation
/priority important-longterm |
d07388d
to
a4de660
Compare
/test pull-kubernetes-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks :-)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, MrHohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
@BenTheElder Thanks for the review :) |
/retest Review the full test history for this PR. Silence the bot with an |
2 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
While looking at the test logs from service controller, I found it hard to parse meaningful information out as I see tons of services named
"service"
or"service1"
. This PR gives test service meaningful name to make the debug experience less painful.Which issue(s) this PR fixes:
Fixes #NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?: