Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable kubelet local endpoints on windows #78704

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Disable kubelet local endpoints on windows #78704

merged 1 commit into from
Jun 4, 2019

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jun 4, 2019 •
edited

What type of PR is this?
/kind bug
/sig node
/priority critical-urgent

What this PR does / why we need it:
This PR removes the local endpoint support for windows, and allows the kubelet to start up without the endpoint on unsupported OS's. The LocalEndpoint support for windows added in previous releases did not work and did not have adequate testing.

Disabling this broken functionality was discussed and approved at sig-windows on June 4th, 2019. Notes

Which issue(s) this PR fixes:
Fixes #78628

Does this PR introduce a user-facing change?:

NONE

/assign @yujuhong @PatrickLang

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 4, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 4, 2019
@yujuhong yujuhong added this to the v1.15 milestone Jun 4, 2019
This was referenced Jun 4, 2019
Closed
Closed
@PatrickLang
Copy link
Contributor

Other than the error message consistency nit, LGTM

@PatrickLang
Copy link
Contributor

/sig windows
FYI - we also discussed this in the SIG-Windows meeting today and didn't have any objections to disabling this feature as its untested on Windows. agenda: https://docs.google.com/document/d/1Tjxzjjuy4SQsFSUVXZbvqVb64hjNAG5CQX8bK7Yda9w/edit#

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jun 4, 2019
@yujuhong
Copy link
Contributor

yujuhong commented Jun 4, 2019

/approve
Leaving lgtm to @PatrickLang to see if he wants to test this manually.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2019
@PatrickLang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2019
@PatrickLang
Copy link
Contributor

Thanks for all the help on this!

@PatrickLang PatrickLang added this to In Progress+Review in SIG-Windows Jun 4, 2019
@dashpole
Copy link
Contributor Author

dashpole commented Jun 4, 2019

/retest

@yujuhong
Copy link
Contributor

yujuhong commented Jun 4, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit b3b1c7c into kubernetes:master Jun 4, 2019
SIG-Windows automation moved this from In Progress+Review to Done (v1.15) Jun 4, 2019
@ddebroy ddebroy mentioned this pull request Feb 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickLang PatrickLang PatrickLang left review comments

@sjenning sjenning Awaiting requested review from sjenning

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@yujuhong yujuhong

@PatrickLang PatrickLang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

Windows kubelet won't start "Failed to create listener for podResources endpoint"
4 participants
@dashpole @PatrickLang @yujuhong @k8s-ci-robot