Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some golint failures of pkg/registry #78718

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Fix some golint failures of pkg/registry #78718

merged 1 commit into from
Jun 22, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jun 5, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Fix some golint failures of pkg/registry:

  • pkg/registry/admissionregistration/mutatingwebhookconfiguration/storage
  • pkg/registry/admissionregistration/validatingwebhookconfiguration/storage
  • pkg/registry/apps/daemonset/storage
  • pkg/registry/autoscaling/horizontalpodautoscaler/storage
  • pkg/registry/batch/cronjob/storage
  • pkg/registry/batch/job/storage

Which issue(s) this PR fixes:

Ref #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 5, 2019
@BenTheElder
Copy link
Member

/unassign
not a reviewer for pkg/, and the hack change is just removing these files from the failures list, doesn't really need review.

@BenTheElder
Copy link
Member

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from BenTheElder June 5, 2019 21:16
@SataQiu
Copy link
Member Author

SataQiu commented Jun 17, 2019

/assign @fejta @liggitt

@SataQiu
Copy link
Member Author

SataQiu commented Jun 19, 2019

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2019
fejta
fejta reviewed Jun 19, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@SataQiu
Copy link
Member Author

SataQiu commented Jun 21, 2019

/assign @thockin

thockin
thockin reviewed Jun 21, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
fejta
fejta reviewed Jun 21, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fejta
Copy link
Contributor

fejta commented Jun 21, 2019

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, SataQiu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 3c7e2a7 into kubernetes:master Jun 22, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@thockin thockin thockin left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@fejta fejta

@liggitt liggitt

@thockin thockin

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@SataQiu @BenTheElder @fejta @k8s-ci-robot @fejta-bot @thockin @liggitt @wojtek-t