-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IPv6 on e2e StatefulSet tests #78871
Conversation
Hi @aojea. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @BenTheElder |
/assign @neolit123 |
what's the delta in image size? are we using httpd anywhere else in the tests? (pretty sure we use nginx frequently). |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test/e2e/apps/types.go
Outdated
// NewNginxImage is the fully qualified URI to the NginxNew image | ||
NewNginxImage = imageutils.GetE2EImage(imageutils.NginxNew) | ||
// NewWebserverImage is the fully qualified URI to the Httpd22 image | ||
NewWebserverImage = imageutils.GetE2EImage(imageutils.Httpd22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name assigned to Httpd22 seems to be NewWebserverImage
but 2.2-alpine
is probably older than 2.4-alpine
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I have to read the test code again, don;t know if is new as in different or new as in newer
/hold @BenTheElder good catch, the delta is big , almost 9x in my host, however dockerhub only repotrs 40MB for the httpd image 🤔
let me check if there is another way to use nginx with ipv6 without creating a new image |
Grepping for nginx in the EDIT
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
test/utils change
/approve cancel Can you actually get someone from sig-apps to review and approve this first? Once you do I can approve the test/utils (and test/e2e/framework) changes. /assign janetkuo nikhiljindal kargakis mfojtik |
a0c1904
to
5601adf
Compare
/hold cancel |
Use httpd docker images instead of nginx because they listen by default both in IPv4 and IPv6
@janetkuo could you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fejta the changes in tests/e2e/apps are just renames, (s/nginx/webserver/ || s/nginx/httpd/), the functional changes are in the framework code and are just:
- use httpd instead of nginx
- update the static html path
mv
ed to match httpd instead of nginx
This looks good to me, thanks!
/lgtm
/approve
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
It adds IPv6 support to the
[sig-apps] StatefulSet [k8s.io] Basic StatefulSet functionality [StatefulSetBasic]
testsWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Nginx official docker images only listen on IPv4 by default, however, Apache httpd listen in both IPv4 and IPv6 and offers the same functionality for the e2e tests.
xref #70248
Does this PR introduce a user-facing change?: