Inverted error handling to ensure server-side apply does not fall bac… #78887
Conversation
…k on client-side apply when there is an error
|
Welcome @joshmsamuels! |
k8s-ci-robot
added
the
size/M
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
Hi @joshmsamuels. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
k8s-ci-robot
added
area/kubectl
sig/cli
|
/assign @brendandburns |
k8s-ci-robot
added
kind/feature
|
I signed the CLA I am unsure how to re-run the review checks |
|
/retest |
|
@joshmsamuels: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @jennybuckley |
|
/assign apelisse |
| if err != nil { | ||
| return err | ||
| if err != nil { | ||
| if isIncompatibleServerError(err) { |
There was a problem hiding this comment.
I don't know if we still want to special-case this. We could just fail with the given error (which is probably unsupported media type), or return a completely different error. But I'm not super convinced by the klog.Warning.
There was a problem hiding this comment.
You could try this maybe:
if isIncompatibleServerError(err) {
err = fmt.Errorf("Server-side apply not enabled (%v)", err)
}
return errThere was a problem hiding this comment.
I updated this. The only change was slight wording of the error message
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest |
|
/test cla/linuxfoundation |
|
I signed it |
|
/retest |
|
You have to fix the extra-spaces that gofmt doesn't like. it's a good idea in general to have gofmt as a pre-save hook in your editor, or as a pre-commit hook. When you update, we'll see if this fixes the CLA thing. Did you sign with the same address you used to make the commit? |
k8s-ci-robot
removed
the
lgtm
|
@apelisse I updated the code with And yes I did. I used the user joshmsamuels to sign the commit and for the cla signature im not sure why its still failing. Is there any other debugging we can do or should I email their support to see if something went wrong |
|
/retest |
|
@joshmsamuels as it's still not working, I recommend asking for support: https://jira.linuxfoundation.org/servicedesk/customer/portal/4/create/88 |
|
I signed it |
|
/retest |
|
@apelisse Can you please add |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, joshmsamuels, kwiesmueller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I will do that now
…On Tue, Jun 18, 2019 at 2:23 AM Kubernetes Prow Robot < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *APPROVED*
This pull-request has been approved by: *apelisse
<#78887 (comment)>*,
*joshmsamuels <#78887#>*, *kwiesmueller
<#78887 (comment)>*
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- pkg/kubectl/OWNERS
<https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/OWNERS>
[apelisse]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#78887?email_source=notifications&email_token=ADKC7KIF7SDROV2NWFJQCSLP3CSRFA5CNFSM4HW2IAVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX5YE2I#issuecomment-503022185>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADKC7KIOHUBIG3U4PV7MA7TP3CSRFANCNFSM4HW2IAVA>
.
|
|
I signed it |
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
1 similar comment
|
/retest |
Inverted error handling to ensure server-side apply does not fall back on client-side apply when there is an error
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is to prevent server-side apply from falling back on client-side apply when there is an error
Which issue(s) this PR fixes:
Part of issue 73723 is fixed (I dont want the issue to be linked/closed with this PR since it is a small part.
There does not appear to be an issue created just for this
Special notes for your reviewer:
Does this PR introduce a user-facing change?: