Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #78313: Avoid the default server mux #79183

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Automated cherry pick of #78313: Avoid the default server mux #79183

merged 1 commit into from
Jun 28, 2019

Conversation

tallclair
Copy link
Member

@tallclair tallclair commented Jun 19, 2019 •
edited by liggitt

Fixes #81023

Cherry pick of #78313 on release-1.13.

#78313: Avoid the default server mux

Fixes CVE-2019-11248: /debug/pprof exposed on kubelet's healthz port

/sig node
/priority important-soon
/kind bug

/assign @dashpole

@k8s-ci-robot
Copy link
Contributor

@tallclair: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 19, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 19, 2019
@tallclair
Copy link
Member Author

/retest

@dashpole
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019
@tpepper tpepper mentioned this pull request Jun 20, 2019
Merged
@tpepper
Copy link
Member

tpepper commented Jun 20, 2019

The parent PR #78313 is marked as kind/cleanup but the #79182, #79183, #79184 cherry picks against 1.1[234] are marked as kind/bug.

@kubernetes/sig-node-pr-reviews and @kubernetes/sig-api-machinery-pr-reviews what are your thoughts on this set of cherry picks?

@tpepper tpepper mentioned this pull request Jun 20, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Jun 22, 2019

@kubernetes/sig-node-pr-reviews and @kubernetes/sig-api-machinery-pr-reviews what are your thoughts on this set of cherry picks?

Added kind/bug to the parent PR. I'm in favor of this fix. Using a specific mux ensures we only serve what we intend to.

/lgtm
/approve

@liggitt liggitt added this to the v1.13 milestone Jun 22, 2019
@hoegaarden
Copy link
Contributor

Can you please all see to get this approved, so we can bring this changed in on all release branches. Thanks!

cc: @kubernetes/sig-node-pr-reviews

@yujuhong
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tallclair, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2019
@hoegaarden hoegaarden added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 28, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@hoegaarden
Copy link
Contributor

/hold
... so fejta-bot stops re-testing -- until #79501 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2019
@hoegaarden
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2019
@hoegaarden
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8ab5246 into kubernetes:release-1.13 Jun 28, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 6, 2019
@liggitt liggitt mentioned this pull request Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

@dashpole dashpole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tallclair @k8s-ci-robot @dashpole @tpepper @liggitt @hoegaarden @yujuhong @fejta-bot