Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/kubectl/util/certificate to staging #79185

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Move pkg/kubectl/util/certificate to staging #79185

merged 3 commits into from
Jun 27, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jun 19, 2019

/kind cleanup
/sig cli
/area kubectl

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Jun 19, 2019
@seans3 seans3 changed the title Move pkg/kubectl/util/certificate to staging [WIP] Move pkg/kubectl/util/certificate to staging Jun 19, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 19, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 19, 2019

/retest

@seans3 seans3 changed the title [WIP] Move pkg/kubectl/util/certificate to staging Move pkg/kubectl/util/certificate to staging Jun 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 19, 2019

/cc @soltysh

@seans3
Copy link
Contributor Author

seans3 commented Jun 20, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Jun 21, 2019

/cc @monopole

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 26, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 26, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 26, 2019

/uncc @juanvallejo
/uncc @cblecker

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 26, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 26, 2019

/cc @apelisse

@seans3
Copy link
Contributor Author

seans3 commented Jun 26, 2019

/uncc @monopole
/remove-area dependency
/remove-area release-eng

@k8s-ci-robot k8s-ci-robot removed the request for review from monopole June 26, 2019 22:00
@k8s-ci-robot k8s-ci-robot removed area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject labels Jun 26, 2019
@apelisse
Copy link
Member

/approve

for modules.txt

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 26, 2019

/cc @Liujingfang1

@Liujingfang1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 805c378 into kubernetes:master Jun 27, 2019
@seans3 seans3 deleted the move-kubectl-util branch August 21, 2019 21:52
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79185 from seans3/move-kubectl-util
4dccadc 
Move pkg/kubectl/util/certificate to staging

Kubernetes-commit: 805c378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@apelisse apelisse Awaiting requested review from apelisse

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees

@Liujingfang1 Liujingfang1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seans3 @apelisse @k8s-ci-robot @Liujingfang1