Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/kubectl/util/term, pkg/kubectl/util/interrupt, pkg/kubectl/util/templates to staging #79192

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Move pkg/kubectl/util/term, pkg/kubectl/util/interrupt, pkg/kubectl/util/templates to staging #79192

merged 1 commit into from
Jun 21, 2019
+351 −183

Conversation

pswica
Copy link
Contributor

@pswica pswica commented Jun 19, 2019 •
edited

  • Moves Move pkg/kubectl/util/term, pkg/kubectl/util/interrupt, pkg/kubectl/util/templates to staging.
  • Publishes this code to the new kubectl repository: https://github.com/kubernetes/kubectl/pkg/util/term
  • Code will be available for re-use after publishing.

/kind cleanup
/sig cli
/area kubectl

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/kubectl size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @pswica. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jun 19, 2019
@pswica
Copy link
Contributor Author

pswica commented Jun 19, 2019

/cc @soltysh @seans3

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 19, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 19, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 19, 2019
seans3
seans3 suggested changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The repository will not allow merge commits; you'll have to rebase. The instructions are here:

https://github.com/kubernetes/community/blob/master/contributors/guide/github-workflow.md#4-keep-your-branch-in-sync

A bunch of the modified files only have minor comments like:

// Run hack/pin-dependency.sh to change pinned dependency versions.
// Run hack/update-vendor.sh to update go.mod files and the vendor directory.

I guess hack/update-vendor.sh did this, but I think we should remove these files from the PR.

@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/priority longterm-important

@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019
@pswica
Copy link
Contributor Author

pswica commented Jun 20, 2019

/retest

@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/remove-sig testing
/remove-area test

@k8s-ci-robot k8s-ci-robot removed sig/testing Categorizes an issue or PR as relevant to SIG Testing. area/test labels Jun 20, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/remove-area code-generation

@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/cc @nikhita

@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 20, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/remove-priority important-longterm

@k8s-ci-robot k8s-ci-robot removed the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jun 20, 2019
@Liujingfang1
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Liujingfang1: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@monopole
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole, pswica

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 20, 2019

/retest

2 similar comments
@pswica
Copy link
Contributor Author

pswica commented Jun 21, 2019

/retest

@seans3
Copy link
Contributor

seans3 commented Jun 21, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5a7b978 into kubernetes:master Jun 21, 2019
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79192 from pswica/util-term
a293b3f 
Move pkg/kubectl/util/term, pkg/kubectl/util/interrupt, pkg/kubectl/util/templates to staging

Kubernetes-commit: 5a7b978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seans3 seans3 seans3 requested changes

@soltysh soltysh Awaiting requested review from soltysh

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@monopole monopole Awaiting requested review from monopole

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@monopole monopole

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pswica @k8s-ci-robot @seans3 @jennybuckley @Liujingfang1 @monopole