Move pkg/kubectl/util/printers to staging #79200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/cc @seans3 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
seans3
reviewed
Jun 20, 2019
|
/approve |
|
/cc @monopole |
k8s-ci-robot
removed
the
lgtm
|
/cc @apelisse |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
apelisse
reviewed
Jun 21, 2019
| @@ -8,6 +8,7 @@ require ( | |||
| github.com/Azure/go-ansiterm v0.0.0-20170929234023-d6e3b3328b78 // indirect | |||
| github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd | |||
| github.com/docker/docker v0.7.3-0.20190327010347-be7ac8be2ae0 | |||
| github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de | |||
There was a problem hiding this comment.
That looks new and weird, what's going on?
There was a problem hiding this comment.
OK Actually I think it makes sense to add that dependency.
|
for the go mod/vendoring part: |
k8s-ci-robot
added
the
approved
|
/unassign @monopole |
|
/uncc @monopole |
|
/uncc @juanvallejo |
|
/approved |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, damemi, monopole, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/uncc dims |
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
Move pkg/kubectl/util/printers to staging Kubernetes-commit: 5f88b0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
/sig cli
/area kubectl