Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/kubectl/utils/{resource,qos} staging #79207

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Move pkg/kubectl/utils/{resource,qos} staging #79207

merged 2 commits into from
Jun 26, 2019

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Jun 20, 2019 

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @sallyom. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 20, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims, juanvallejo and a team June 20, 2019 04:08
@sallyom sallyom force-pushed the move-pkg-kubectl-utils-resource-stg branch from 63bf759 to 3599c5d Compare June 20, 2019 12:48
@sallyom
Copy link
Contributor Author

sallyom commented Jun 20, 2019

@nikhita I'm getting this with the 2 other PRs I've made the import-restrictions/publishing changes in, hm.. also, mind /ok-to-test this? thanks

@nikhita
Copy link
Member

nikhita commented Jun 20, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Jun 20, 2019

@nikhita I think maybe i need to rebase then update-vendor, doing that now : )

@sallyom sallyom force-pushed the move-pkg-kubectl-utils-resource-stg branch from 3599c5d to b10ca7a Compare June 20, 2019 15:03
@seans3
Copy link
Contributor

seans3 commented Jun 21, 2019

/cc @monopole

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2019
@sallyom sallyom force-pushed the move-pkg-kubectl-utils-resource-stg branch from b10ca7a to ccc4349 Compare June 25, 2019 03:04
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2019
@nikhita
Copy link
Member

nikhita commented Jun 26, 2019

nit: can you squash the Remove unused BUILD files commits and Updates to dependencies including go.mod, go.sum, and BUILD files commits into a single commit? 😬

@nikhita nikhita changed the title Move pkg/kubectl/utils/resource staging Move pkg/kubectl/utils/{resource,qos} staging Jun 26, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 26, 2019

/uncc @juanvallejo
/uncc @monopole
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 26, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 26, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 26, 2019

/cc @apelisse

@apelisse
Copy link
Member

/approve

for modules.txt

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, sallyom, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2019
@pswica
Copy link
Contributor

pswica commented Jun 26, 2019

/retest

@seans3
Copy link
Contributor

seans3 commented Jun 26, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2019
@sallyom sallyom force-pushed the move-pkg-kubectl-utils-resource-stg branch from de223bd to c4cb265 Compare June 26, 2019 19:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 26, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Jun 26, 2019

@nikhita i've squashed as you suggested. thanks for your review : )

@k8s-ci-robot k8s-ci-robot merged commit bb4d8d6 into kubernetes:master Jun 26, 2019
@sallyom sallyom mentioned this pull request Sep 12, 2019
Closed
6 tasks
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79207 from sallyom/move-pkg-kubectl-uti…
f28aa45 
…ls-resource-stg

Move pkg/kubectl/utils/{resource,qos} staging

Kubernetes-commit: bb4d8d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@dims dims Awaiting requested review from dims

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sallyom @k8s-ci-robot @nikhita @seans3 @apelisse @pswica