-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation on OutputFormatType references nonexistent file #79236
Documentation on OutputFormatType references nonexistent file #79236
Conversation
Welcome @connor1989! |
Hi @connor1989. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @brendandburns |
@dixudx mentioned source and docs are moved to cli-runtime and present at staging/src/k8s.io/cli-runtime/xxxx. Leaving the change of removal in the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Just removing useless doc here.
/lgtm
ping @kubernetes/sig-cli-maintainers for approval. |
/test pull-kubernetes-integration |
/assign @deads2k All of the available outputting formats are described within this kubectl Cobra command. All of the formats are still supported with the only exception being the removal of a shorthand flag. Not sure if it would be more beneficial to update the PR by replacing the referenced file path to the one above or to copy the list into the comment ? |
/unassign @brendandburns |
pkg/printers/interface.go
Outdated
@@ -39,7 +39,6 @@ func (fn ResourcePrinterFunc) PrintObj(obj runtime.Object, w io.Writer) error { | |||
|
|||
// PrintOptions struct defines a struct for various print options | |||
type PrintOptions struct { | |||
// supported Format types can be found in pkg/printers/printers.go | |||
OutputFormatType string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two values are never used. Please delete them both.
…re no longer used.
adb4a93
to
265fd04
Compare
@dixudx could you take another pass through on the review for the lgtm |
/test pull-kubernetes-e2e-gce |
/retest |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor1989, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/uncc @ghodss |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Reviewing the PrintOptions in the printing package indicates more information can be found in
pkg/printers/printers.go
. This file was removed around the time of 1.10. The comment is no longer useful.Fixes #
Does this PR introduce a user-facing change?:
NO