Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Replaces images used with agnhost (part 3) #79238

Merged
merged 1 commit into from
Jun 28, 2019
Merged

tests: Replaces images used with agnhost (part 3) #79238

merged 1 commit into from
Jun 28, 2019

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jun 20, 2019 •
edited

What type of PR is this?

/kind feature

/sig testing

What this PR does / why we need it:

Quite a few images are only used a few times in a few tests. Thus, the images are being centralized into the agnhost image, reducing the number of images that have to be pulled and used.

This PR replaces the usage of the following images with agnhost:

  • audit-proxy
  • crd-conversion-webhook
  • entrypoint-tester
  • inclusterclient
  • iperf
  • porter
  • serve-hostname

Which issue(s) this PR fixes:

Partially Fixes #76342
Depends On: #79142

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2019
@claudiubelu claudiubelu mentioned this pull request Jun 20, 2019
Merged
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jun 20, 2019
@claudiubelu claudiubelu force-pushed the tests/reduce-to-agnhost-part-3 branch from d2a5789 to 3dd25af Compare June 20, 2019 20:37
@spiffxp
Copy link
Member

spiffxp commented Jun 20, 2019

/assign @spiffxp @johnSchnake
/area conformance
I know that at least porter is involved in some of the conformance tests

@k8s-ci-robot k8s-ci-robot added the area/conformance Issues or PRs related to kubernetes conformance tests label Jun 20, 2019
@spiffxp spiffxp added this to To Triage in conformance-definition via automation Jun 20, 2019
@spiffxp spiffxp moved this from To Triage to In Progress in conformance-definition Jun 20, 2019
@spiffxp
Copy link
Member

spiffxp commented Jun 20, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2019
@spiffxp
Copy link
Member

spiffxp commented Jun 20, 2019

/hold
until images from #79142 are built and it's been merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2019
@claudiubelu claudiubelu force-pushed the tests/reduce-to-agnhost-part-3 branch 3 times, most recently from 47ee682 to 46b32be Compare June 25, 2019 13:48
@spiffxp
Copy link
Member

spiffxp commented Jun 26, 2019

/retest
images have been pushed per #79142 (comment)

spiffxp
spiffxp suggested changes Jun 26, 2019
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main concern here is a few places that assume an image param is always going to be agnhost, otherwise LGTM

test/e2e/common/docker_containers.go Outdated Show resolved Hide resolved
test/e2e/scalability/load.go Outdated Show resolved Hide resolved
test/e2e/scheduling/ubernetes_lite.go Outdated Show resolved Hide resolved
test/e2e/scheduling/ubernetes_lite.go Outdated Show resolved Hide resolved
test/e2e/upgrades/apps/daemonsets.go Show resolved Hide resolved
@spiffxp spiffxp mentioned this pull request Jun 26, 2019
Merged
@claudiubelu claudiubelu force-pushed the tests/reduce-to-agnhost-part-3 branch from 46b32be to 9a6b2c2 Compare June 26, 2019 11:45
@claudiubelu
Copy link
Contributor Author

@spiffxp Hm, interesting. Since when is this a thing, I wonder. It seems that some tests are also expecting the agnhost image to exist in the private registry (gcr.io/k8s-authenticated-test/agnhost:2.2):

[sig-apps] ReplicaSet should serve a basic image on each replica with a private image
[sig-apps] ReplicationController should serve a basic image on each replica with a private image

Can you also push the image there?

@claudiubelu claudiubelu force-pushed the tests/reduce-to-agnhost-part-3 branch from 9a6b2c2 to e62341d Compare June 26, 2019 14:29
@claudiubelu
Copy link
Contributor Author

claudiubelu commented Jun 26, 2019 •
edited

Hm, it seems that there are only 3 test failures, 2 of them caused by the fact that the agnhost image does not exist in the authenticated registry, and one regarding entrypoint-tester with default arguments. Apparently, it is waiting for the pod to enter a Completed state, which ofc it never happens (pause is being run by default). Will have to do something about it.

@claudiubelu
tests: Replaces images used with agnhost (part 3)
c752ea8 
Quite a few images are only used a few times in a few tests. Thus,
the images are being centralized into the agnhost image, reducing
the number of images that have to be pulled and used.

This PR replaces the usage of the following images with agnhost:

- audit-proxy
- crd-conversion-webhook
- entrypoint-tester
- inclusterclient
- iperf
- porter
- serve-hostname
@claudiubelu claudiubelu force-pushed the tests/reduce-to-agnhost-part-3 branch from e62341d to c752ea8 Compare June 26, 2019 20:34
@spiffxp
Copy link
Member

spiffxp commented Jun 27, 2019 •
edited

/retest
using images pushed via #79142 (comment)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 27, 2019 •
edited

@BCLAU: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e-containerd c752ea8 link /test pull-kubernetes-node-e2e-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@claudiubelu
Copy link
Contributor Author

/retest

@spiffxp
Copy link
Member

spiffxp commented Jun 28, 2019

It seems like tests are happy at this point

@spiffxp
Copy link
Member

spiffxp commented Jun 28, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bclau, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2019
@spiffxp
Copy link
Member

spiffxp commented Jun 28, 2019

/hold cancel
Happy with #79142 as well and assume it will merge before this

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit d1d1114 into kubernetes:master Jun 28, 2019
conformance-definition automation moved this from In Progress to Done Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp requested changes

@bsalamat bsalamat Awaiting requested review from bsalamat

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@spiffxp spiffxp

@johnSchnake johnSchnake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
conformance-definition
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate test images and improve documentation
4 participants
@claudiubelu @spiffxp @k8s-ci-robot @johnSchnake