Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add Bind extension point of the scheduling framework" #79296

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Revert "Add Bind extension point of the scheduling framework" #79296

merged 1 commit into from
Jun 22, 2019

Conversation

draveness
Copy link
Contributor

@draveness draveness commented Jun 22, 2019 •
edited

What type of PR is this?

/kind bug
/kind flake
/priority important-soon
/sig scheduling

What this PR does / why we need it:

The TestBindPlugin is flaky, revert it to unblock other affected PRs.

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79294/pull-kubernetes-integration/1142430172373323779/
https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78097/pull-kubernetes-integration/1142370400089411584/

Which issue(s) this PR fixes:

Ref #79297
#78513

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 22, 2019
@draveness
Copy link
Contributor Author

/assign @bsalamat

cc/ @chenchun @tedyu

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 22, 2019
@tedyu
Copy link
Contributor

tedyu commented Jun 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2019
@bsalamat
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, draveness

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 55ff389 into kubernetes:master Jun 22, 2019
@draveness draveness deleted the feature/revert-bind-extension-point branch June 23, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat Awaiting requested review from bsalamat

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@tedyu tedyu

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@draveness @tedyu @bsalamat @k8s-ci-robot