Clean up self-set node labels

[paivagustavo]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind cleanup

What this PR does / why we need it:
Finishes the clean up self-set kubelet labels under k8s.io prefixes:

This is related to https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/0000-20170814-bounding-self-labeling-kubelets.md#implementation-timeline
And is the follow up from #74424

Which issue(s) this PR fixes:

Fixes #75050

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

* Node labels `beta.kubernetes.io/metadata-proxy-ready`, `beta.kubernetes.io/metadata-proxy-ready` and `beta.kubernetes.io/kube-proxy-ds-ready` are no longer added on new nodes.
* ip-mask-agent addon starts to use the label `node.kubernetes.io/masq-agent-ds-ready` instead of `beta.kubernetes.io/masq-agent-ds-ready` as its node selector.
* kube-proxy addon starts to use the label `node.kubernetes.io/kube-proxy-ds-ready` instead of `beta.kubernetes.io/kube-proxy-ds-ready` as its node selector.
* metadata-proxy addon starts to use the label `cloud.google.com/metadata-proxy-ready` instead of `beta.kubernetes.io/metadata-proxy-ready` as its node selector.
* Kubelet removes the ability to set `kubernetes.io` or `k8s.io` labels via --node-labels other than the [specifically allowed labels/prefixes](https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/0000-20170814-bounding-self-labeling-kubelets.md#proposal).

[k8s-ci-robot]

Welcome @paivagustavo!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @paivagustavo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[draveness]

/lgtm
/ok-to-test
/priority backlog

/assign @liggitt

[gaorong]

also need change at here:

kubernetes/cmd/kubelet/app/options/options.go

Lines 250 to 252 in bc8ea43

	// TODO(liggitt): in 1.16, return an error
	klog.Warningf("unknown 'kubernetes.io' or 'k8s.io' labels specified with --node-labels: %v", unknownLabels.List())
	klog.Warningf("in 1.16, --node-labels in the 'kubernetes.io' namespace must begin with an allowed prefix (%s) or be in the specifically allowed set (%s)", strings.Join(kubeletapis.KubeletLabelNamespaces(), ", "), strings.Join(kubeletapis.KubeletLabels(), ", "))

[paivagustavo]

Hey @gaorong I've added the changes that you pointed out.

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, paivagustavo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster/addons/ip-masq-agent/OWNERS [liggitt]
• cluster/addons/kube-proxy/OWNERS [liggitt]
• cluster/addons/metadata-proxy/OWNERS [liggitt]
• cluster/gce/OWNERS [liggitt]
• cmd/kubelet/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rnsv]

With this change, I see that node-role.kubernetes.io is not allowed. Is there an alternate label available to set the node role via --node-lables?

[den-is]

I second @rnsv qeustion?

What is the best practice to setup node-role master during the initial bootstrap (automatically) ?

[eranreshef]

I'm joining @rnsv and @den-is question. How can I set node-role during boot?

[rnsv]

Created a new issue #85073 . This seems like an easy fix if we add kubernetes.io/role in

kubernetes/pkg/kubelet/apis/well_known_labels.go

Lines 39 to 52 in 939e1e6

	var kubeletLabels = sets.NewString(
	v1.LabelHostname,
	v1.LabelZoneFailureDomainStable,
	v1.LabelZoneRegionStable,
	v1.LabelZoneFailureDomain,
	v1.LabelZoneRegion,
	v1.LabelInstanceType,
	v1.LabelInstanceTypeStable,
	v1.LabelOSStable,
	v1.LabelArchStable,
	LabelOS,
	LabelArch,
	)

Any thoughts?